[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6913: Core: ReachableFileUtil.versionHintLocation() should not fail for table location with just bucket name

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #6913:
URL: https://github.com/apache/iceberg/pull/6913#discussion_r1128704779


##########
core/src/main/java/org/apache/iceberg/ReachableFileUtil.java:
##########
@@ -45,7 +45,7 @@ private ReachableFileUtil() {}
    */
   public static String versionHintLocation(Table table) {
     // only Hadoop tables have a hint file and such tables have a fixed metadata layout
-    Path metadataPath = new Path(table.location(), METADATA_FOLDER_NAME);
+    Path metadataPath = new Path(table.location() + "/" + METADATA_FOLDER_NAME);
     Path versionHintPath = new Path(metadataPath, Util.VERSION_HINT_FILENAME);

Review Comment:
   Why don't we need a similar +"/" here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org