[jira] [Resolved] (CALCITE-3287) Union's getRowCount in RelMdRowCount has not consider 'union all'

["Haisheng Yuan (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Haisheng Yuan resolved CALCITE-3287.
------------------------------------
    Fix Version/s: 1.22.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/9693817df9421fda9a727d03b225f686f5393def, thanks for the PR, [~shenhong]!

> Union's getRowCount in RelMdRowCount has not consider 'union all'
> -----------------------------------------------------------------
>
>                 Key: CALCITE-3287
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3287
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Hong Shen
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> when I read the RelMdRowCount.java, I found that union's getRowCount has not consider 'union all', while in Union.estimateRowCount has. I am not sure whether this is a bug, if it is, I can help fix it.
> {code:java}
> RelMdRowCount.java
> public Double getRowCount(Union rel, RelMetadataQuery mq) {
>     double rowCount = 0.0;
>     for (RelNode input : rel.getInputs()) {
>       Double partialRowCount = mq.getRowCount(input);
>       if (partialRowCount == null) {
>         return null;
>       }
>       rowCount += partialRowCount;
>     }
>     return rowCount;
>   }
> Union.java
>   @Override public double estimateRowCount(RelMetadataQuery mq) {
>     double dRows = RelMdUtil.getUnionAllRowCount(mq, this);
>     if (!all) {
>       dRows *= 0.5;
>     }
>     return dRows;
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)