You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/03/23 21:11:25 UTC
[GitHub] tinkerpop pull request #825: TINKERPOP-1930 Remove Giraph
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/825
TINKERPOP-1930 Remove Giraph
https://issues.apache.org/jira/browse/TINKERPOP-1930
Build time with integration test is less than half without giraph - nice. Not much more to say.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1930
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/825.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #825
----
commit ed5924c3373946d9ccef3f30a370f8f28dcea52d
Author: Stephen Mallette <sp...@...>
Date: 2018-03-23T12:20:05Z
TINKERPOP-1930 Remove Giraph
----
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/825
i meant to come back to that pom.xml and forgot. seems ok to drop the two exclusions now that giraph is gone. didn't get any new conflicts in doing so when i built.
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/825
VOTE +1
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/825
I think there's more that can be removed:
```diff
diff --git a/pom.xml b/pom.xml
index ef2be4821d..ddd9167a51 100644
--- a/pom.xml
+++ b/pom.xml
@@ -582,15 +582,6 @@ limitations under the License.
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
- <!-- conflicts with giraph-core (which appears to have more consistent dependencies) -->
- <exclusion>
- <groupId>org.codehaus.jackson</groupId>
- <artifactId>jackson-core-asl</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.codehaus.jackson</groupId>
- <artifactId>jackson-mapper-asl</artifactId>
- </exclusion>
<!-- conflict with TinkerPop tests -->
<exclusion>
<groupId>junit</groupId>
@@ -1146,7 +1137,7 @@ limitations under the License.
<overview>${basedir}/docs/javadoc/overview.html</overview>
<quiet>true</quiet>
<sourcepath>
- giraph-gremlin/src/main/java:gremlin-core/src/main/java:gremlin-driver/src/main/java:gremlin-groovy/src/main/java:gremlin-python/src/main/java:gremlin-server/src/main/java:gremlin-test/src/main/java:hadoop-gremlin/src/main/java:neo4j-gremlin/src/main/java:spark-gremlin/src/main/java:tinkergraph-gremlin/src/main/java
+ gremlin-core/src/main/java:gremlin-driver/src/main/java:gremlin-groovy/src/main/java:gremlin-python/src/main/java:gremlin-server/src/main/java:gremlin-test/src/main/java:hadoop-gremlin/src/main/java:neo4j-gremlin/src/main/java:spark-gremlin/src/main/java:tinkergraph-gremlin/src/main/java
</sourcepath>
</configuration>
</execution>
```
However, `docker/build.sh -d` fails with an `AbstractMethodError` in Spark, but I'm afraid that's a problem in other branches as well.
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/825
Should get a CHANGELOG entry, right?
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/825
added changelog entry
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/825
Best PR ever ;)
VOTE: +1
---
[GitHub] tinkerpop pull request #825: TINKERPOP-1930 Remove Giraph
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/825
---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/825
Can this be merged?
---