[jira] [Commented] (FELIX-4025) Cleanup InventoryPrinter API

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636843#comment-13636843 ] 

Felix Meschberger commented on FELIX-4025:
------------------------------------------

In Rev. 1470022 I also adapted the ZipAttachementProvider.addAttachements method to have similar ordering as the InventoryPrinter.print method, which lists the output channel first ahead of further arguments.
                
> Cleanup InventoryPrinter API
> ----------------------------
>
>                 Key: FELIX-4025
>                 URL: https://issues.apache.org/jira/browse/FELIX-4025
>             Project: Felix
>          Issue Type: Improvement
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: inventory-1.0.0
>
>         Attachments: FELIX-4025.patch
>
>
> The current draft Inventory Printer service API has some problems:
> * The PrinterMode class does not really describe a mode but rather a format. So it should be called Format instead.
> * The InventoryPrinter.print method somewhat randomly lists its arguments. I think they should be reorded to read PrintWriter, Format (aka PrinterMode), boolean.
> * The InventoryPrinter requires three service registration properties. While it makes absolute sense to have them defined, I am not sure, whether we should require them. So I propose the following defaults:
>    * ..format: Format.TEXT
>    * ..name: InventoryPrinter+<service.id>
>    * ..title: same as name
> * Rename the InventoryPrinter service properties removing the "CONFIG_" prefix

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira