You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/28 15:37:31 UTC
[GitHub] [echarts] Justineo opened a new issue, #16961: [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false`
Justineo opened a new issue, #16961:
URL: https://github.com/apache/echarts/issues/16961
### Version
5.3.2
### Link to Minimal Reproduction
https://codepen.io/Justineo/pen/rNJBNzz
### Steps to Reproduce
1. Create a chart with the dataZoom component.
2. Adjust data zooming.
3. Call `setOption({ series: newData, dataZoom: oldDataZoom }, { notMerge: false })`.
### Current Behavior
Previous zooming is reset after setting new option.
### Expected Behavior
Previous zooming is kept.
### Environment
```markdown
- OS: macOS Monterey
- Browser: Chrome 99.0.4844.84
- Framework: N/A
```
### Any additional comments?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Justineo commented on issue #16961: [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false`
Posted by GitBox <gi...@apache.org>.
Justineo commented on issue #16961:
URL: https://github.com/apache/echarts/issues/16961#issuecomment-1112824675
Just switch the toggle in the reproduction above and you'll see the chart won't render from the beginning if `dataZoom` is not provided in the `option`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on issue #16961: [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false`
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on issue #16961:
URL: https://github.com/apache/echarts/issues/16961#issuecomment-1112781441
Since how Echarts works is to render everything from scratch after `option` has changed, I guess it is expected to see the data zoom be reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on issue #16961: [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false`
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on issue #16961:
URL: https://github.com/apache/echarts/issues/16961#issuecomment-1112807683
As I understand, `notMerge` is the mode to **merge `option`**, meaning destroying the old `option` and apply the new `option`. That doesn't mean not to render the chart from the beginning. Please refer to https://echarts.apache.org/en/api.html#echartsInstance.setOption.
Also the option `lazyUpdate` is preventing the chart to update immediately, would that help you with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Justineo commented on issue #16961: [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false`
Posted by GitBox <gi...@apache.org>.
Justineo commented on issue #16961:
URL: https://github.com/apache/echarts/issues/16961#issuecomment-1112799648
Not really. `setOption` has a `notMerge` option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] jiawulin001 commented on issue #16961: [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false`
Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on issue #16961:
URL: https://github.com/apache/echarts/issues/16961#issuecomment-1112836529
Seems you are right, the components that do not change will not be updated. I think it makes sense that the `dataZoom` component is rendered from scratch because it is reset.
But now the original issue seems not to exist at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [I] [Bug] setOption with `dataZoom` property resets zooming even with `notMerge: false` [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #16961:
URL: https://github.com/apache/echarts/issues/16961#issuecomment-2094397070
This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org