[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8947: [thumbnails] thumbnails for dashboards and charts

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8947: [thumbnails] thumbnails for dashboards and charts
URL: https://github.com/apache/incubator-superset/pull/8947#discussion_r405146876
 
 

 ##########
 File path: superset/charts/api.py
 ##########
 @@ -39,9 +41,12 @@
     ChartPostSchema,
     ChartPutSchema,
     get_delete_ids_schema,
+    thumbnail_query_schema,
 )
 from superset.constants import RouteMethod
 from superset.models.slice import Slice
+from superset.tasks.thumbnails import cache_chart_thumbnail
+from superset.utils.selenium import ChartScreenshot
 
 Review comment:
   I wonder if the ChartScreenshot class should be part of a package that isn't named after the underlying implementation? I can see a future where we want to remove Selenium from the stack - other languages have far better tools for this system, and I hope some of them will be ported soon. It would be nice to be able to replace the underlying implementation without touching files from other modules.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org