You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/22 13:12:15 UTC
[GitHub] [superset] kgabryje opened a new issue, #21147: perf(dashboard): Improve performance of the native filters config modal
kgabryje opened a new issue, #21147:
URL: https://github.com/apache/superset/issues/21147
When user has a big dashboard and many native filters added, the filters config modal is very laggy and unresponsive.
We should:
1. Improve the structure of components that build filters config modal (for example `FiltersConfigForm` has over 1200 lines...)
2. Reduce the number of unnecessary rerenders (with `React.memo`, `useCallback`, `useMemo`). To measure and find unnecessary rerenders I recommend library `whyDidYouRender`
3. Measure the performance of filters config modal with Chrome devtools and try to optimize anything that stands out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #21147: perf(dashboard): Improve performance of the native filters config modal
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #21147:
URL: https://github.com/apache/superset/issues/21147#issuecomment-1384232535
Yep!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #21147: perf(dashboard): Improve performance of the native filters config modal
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #21147:
URL: https://github.com/apache/superset/issues/21147#issuecomment-1382679148
@kgabryje should we consider this closed after the aforementioned merged PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #21147: perf(dashboard): Improve performance of the native filters config modal
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #21147: perf(dashboard): Improve performance of the native filters config modal
URL: https://github.com/apache/superset/issues/21147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org