You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/01 06:20:45 UTC

[GitHub] [rocketmq-client-go] fengberlin opened a new pull request #692: fix type assert panic

fengberlin opened a new pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692


   The `sync.Map` store the value 0, its type is `int`, but in that code before fixed, the value `Load` by `sync.Map` is asserted as `int64`, so cause the type assert panic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin closed pull request #692: [ISSUE #688] fix type assert panic

Posted by GitBox <gi...@apache.org>.
fengberlin closed pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] fengberlin commented on pull request #692: [ISSUE #688] fix type assert panic

Posted by GitBox <gi...@apache.org>.
fengberlin commented on pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692#issuecomment-872271059


   OK. I will close this issue and create another PR.
   @wenfengwang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #692: [ISSUE #688] fix type assert panic

Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692#issuecomment-872204724


   link: https://github.com/apache/rocketmq-client-go/issues/688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #692: fix type assert panic

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692#issuecomment-871957761


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#692](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ad8ee4) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **increase** coverage by `0.02%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #692      +/-   ##
   ==========================================
   + Coverage   24.71%   24.74%   +0.02%     
   ==========================================
     Files          48       48              
     Lines        5223     5234      +11     
   ==========================================
   + Hits         1291     1295       +4     
   - Misses       3726     3733       +7     
     Partials      206      206              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [consumer/pull\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVsbF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `29.49% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.86% <100.00%> (+0.61%)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...4ad8ee4](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] codecov-commenter edited a comment on pull request #692: fix type assert panic

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692#issuecomment-871957761


   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#692](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ad8ee4) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/c688c190734dcdb6e2fc9b2f6791544d648185a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c688c19) will **increase** coverage by `0.02%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/graphs/tree.svg?width=650&height=150&src=pr&token=CiV9ofPkG3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #692      +/-   ##
   ==========================================
   + Coverage   24.71%   24.74%   +0.02%     
   ==========================================
     Files          48       48              
     Lines        5223     5234      +11     
   ==========================================
   + Hits         1291     1295       +4     
   - Misses       3726     3733       +7     
     Partials      206      206              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [consumer/pull\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVsbF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.00% <0.00%> (ø)` | |
   | [internal/trace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdHJhY2UuZ28=) | `29.49% <0.00%> (-0.11%)` | :arrow_down: |
   | [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.86% <100.00%> (+0.61%)` | :arrow_up: |
   | [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/692/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c688c19...4ad8ee4](https://codecov.io/gh/apache/rocketmq-client-go/pull/692?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #692: fix type assert panic

Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #692:
URL: https://github.com/apache/rocketmq-client-go/pull/692#issuecomment-872189722


   The changes is LGTM, but could create an issue for this PR so that i can merge the PR @fengberlin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org