[GitHub] [helix] pkuwm commented on a change in pull request #1205: Fix mvn site failure

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464595451



##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-site-plugin</artifactId>
-        <version>3.2</version>
-        <dependencies>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-markdown</artifactId>
-            <version>1.3</version>
-          </dependency>
-        </dependencies>
+        <version>3.9.1</version>

Review comment:
       `doxia-module-markdown` is not a direct dependency in maven-site-plugin 3.2, but it is a dependency in 3.9.1.
   https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-site-plugin/3.9.1
   
   So I think it is fine to remove this dependency. And as I tested it, website htmls are fine. Maybe I have't checked the broken website htmls you talk about. If you could tell me what htmls are broken, I could test to verify.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org