You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/09/19 06:50:49 UTC
Review Request 25817: SENTRY-383: Add TestPrivilegeWithGrantOption to
cluster test profile
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/
-----------------------------------------------------------
Review request for sentry and Sravya Tirukkovalur.
Bugs: SENTRY-383
https://issues.apache.org/jira/browse/SENTRY-383
Repository: sentry
Description
-------
Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
Diffs
-----
sentry-tests/sentry-tests-hive/pom.xml 067d1ab
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
Diff: https://reviews.apache.org/r/25817/diff/
Testing
-------
Added new testcase in TestPrivilegeWithGrantOption.
Thanks,
Prasad Mujumdar
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On Sept. 22, 2014, 6:31 p.m., Sravya Tirukkovalur wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java, line 58
> > <https://reviews.apache.org/r/25817/diff/2/?file=698525#file698525line58>
> >
> > We may need to add "with grant" auth statements to TestDbSentryOnFailureHookLoading to make sure these failed statements are being invoking the hook as we are removing that check here.
That's a valid point. I will refactor the patch to execute the hook check only for internal HS2. That way we can test the failure hook with non-cluster test.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/#review54151
-----------------------------------------------------------
On Sept. 20, 2014, 1 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25817/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2014, 1 a.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-383
> https://issues.apache.org/jira/browse/SENTRY-383
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/pom.xml 067d1ab
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
>
> Diff: https://reviews.apache.org/r/25817/diff/
>
>
> Testing
> -------
>
> Added new testcase in TestPrivilegeWithGrantOption.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/#review54151
-----------------------------------------------------------
Thanks for the patch Prasad! Minor comments below.
sentry-tests/sentry-tests-hive/pom.xml
<https://reviews.apache.org/r/25817/#comment94147>
We need to add this test to cluster-hadoop-provider-db profile instead.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java
<https://reviews.apache.org/r/25817/#comment94148>
Looks like we are not using policyFile, get rid of it?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java
<https://reviews.apache.org/r/25817/#comment94149>
Same as above
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java
<https://reviews.apache.org/r/25817/#comment94154>
We may need to add "with grant" auth statements to TestDbSentryOnFailureHookLoading to make sure these failed statements are being invoking the hook as we are removing that check here.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java
<https://reviews.apache.org/r/25817/#comment94150>
Nit: Remove commented out code?
- Sravya Tirukkovalur
On Sept. 20, 2014, 1 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25817/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2014, 1 a.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-383
> https://issues.apache.org/jira/browse/SENTRY-383
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/pom.xml 067d1ab
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
>
> Diff: https://reviews.apache.org/r/25817/diff/
>
>
> Testing
> -------
>
> Added new testcase in TestPrivilegeWithGrantOption.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/#review54284
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On Sept. 23, 2014, 6:50 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25817/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 6:50 a.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-383
> https://issues.apache.org/jira/browse/SENTRY-383
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/pom.xml 067d1ab
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
>
> Diff: https://reviews.apache.org/r/25817/diff/
>
>
> Testing
> -------
>
> Added new testcase in TestPrivilegeWithGrantOption.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/
-----------------------------------------------------------
(Updated Sept. 23, 2014, 6:50 a.m.)
Review request for sentry and Sravya Tirukkovalur.
Bugs: SENTRY-383
https://issues.apache.org/jira/browse/SENTRY-383
Repository: sentry
Description
-------
Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/pom.xml 067d1ab
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
Diff: https://reviews.apache.org/r/25817/diff/
Testing
-------
Added new testcase in TestPrivilegeWithGrantOption.
Thanks,
Prasad Mujumdar
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/#review54244
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java
<https://reviews.apache.org/r/25817/#comment94254>
This would fail here when using unmanaged hiveserver2 right?
- Sravya Tirukkovalur
On Sept. 23, 2014, 1:22 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25817/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 1:22 a.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-383
> https://issues.apache.org/jira/browse/SENTRY-383
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/pom.xml 067d1ab
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
>
> Diff: https://reviews.apache.org/r/25817/diff/
>
>
> Testing
> -------
>
> Added new testcase in TestPrivilegeWithGrantOption.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/
-----------------------------------------------------------
(Updated Sept. 23, 2014, 1:22 a.m.)
Review request for sentry and Sravya Tirukkovalur.
Changes
-------
Changes per review feedback.
Bugs: SENTRY-383
https://issues.apache.org/jira/browse/SENTRY-383
Repository: sentry
Description
-------
Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/pom.xml 067d1ab
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
Diff: https://reviews.apache.org/r/25817/diff/
Testing
-------
Added new testcase in TestPrivilegeWithGrantOption.
Thanks,
Prasad Mujumdar
Re: Review Request 25817: SENTRY-383: Add
TestPrivilegeWithGrantOption to cluster test profile
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25817/
-----------------------------------------------------------
(Updated Sept. 20, 2014, 1 a.m.)
Review request for sentry and Sravya Tirukkovalur.
Changes
-------
Rebased patch
Bugs: SENTRY-383
https://issues.apache.org/jira/browse/SENTRY-383
Repository: sentry
Description
-------
Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to extend AbstractTestWithStaticConfiguration so that it can be run in cluster mode. Added another test case to verify implied privileges.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/pom.xml 067d1ab
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java 7cd667e
Diff: https://reviews.apache.org/r/25817/diff/
Testing
-------
Added new testcase in TestPrivilegeWithGrantOption.
Thanks,
Prasad Mujumdar