You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by "Matthias Friedrich (JIRA)" <ji...@apache.org> on 2012/07/30 22:47:33 UTC
[jira] [Created] (CRUNCH-28) Add missing license headers
Matthias Friedrich created CRUNCH-28:
----------------------------------------
Summary: Add missing license headers
Key: CRUNCH-28
URL: https://issues.apache.org/jira/browse/CRUNCH-28
Project: Crunch
Issue Type: Bug
Affects Versions: 0.3.0
Reporter: Matthias Friedrich
Assignee: Matthias Friedrich
There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-28) Add missing license headers
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425814#comment-13425814 ]
Josh Wills commented on CRUNCH-28:
----------------------------------
The script should have a header, but I don't think the test data requires it.
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-28) Add missing license headers
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425328#comment-13425328 ]
Matthias Friedrich commented on CRUNCH-28:
------------------------------------------
A license header or an exclusion ;-)
You probably have a file lying around in your working copy that doesn't belong there. See "git status", target/rat.txt (or */target/rat.txt), it tells you which file it is. On my working copy and a freshly cloned repository it works fine.
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-28) Add missing license headers
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425554#comment-13425554 ]
Matthias Friedrich commented on CRUNCH-28:
------------------------------------------
Thanks!
What are we going to do about the licenses of the scrunch script and the integration test data?
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-28) Add missing license headers
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-28:
-------------------------------------
Attachment: 0001-CRUNCH-28-Add-license-headers.patch
I attached the rat plugin to the test phase. Right now it runs quickly, but we could also move it to verify phase.
Please review the licenses of the scrunch script and the integration test data (especially shakes.txt). I'm not sure what to do with test data in general; adding license headers would break the tests.
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-28) Add missing license headers
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425300#comment-13425300 ]
Josh Wills commented on CRUNCH-28:
----------------------------------
I got: [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check (rat-check) on project crunch-parent: Too many unapproved licenses: 1 -> [Help 1]
when I did mvn clean test. What am I missing?
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-28) Add missing license headers
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-28:
-------------------------------------
Fix Version/s: 0.3.0
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.3.0
>
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CRUNCH-28) Add missing license headers
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Wills resolved CRUNCH-28.
------------------------------
Resolution: Fixed
Quite right-- I ran it on a clean branch and it worked fine. Committed-- thanks Matthias!
> Add missing license headers
> ---------------------------
>
> Key: CRUNCH-28
> URL: https://issues.apache.org/jira/browse/CRUNCH-28
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: 0001-CRUNCH-28-Add-license-headers.patch
>
>
> There are still a few files that don't have license headers. We should add those headers and also add an automatic check using Apache Rat to detect this in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira