You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2009/09/18 00:45:57 UTC
[jira] Created: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
-----------------------------------------------------------------------------------------
Key: HADOOP-6267
URL: https://issues.apache.org/jira/browse/HADOOP-6267
Project: Hadoop Common
Issue Type: Improvement
Components: build
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Minor
build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757353#action_12757353 ]
Chris Douglas commented on HADOOP-6267:
---------------------------------------
No, I'm not vetoing it. It doesn't seem useful, but neither is it harmful. If it helps, then sure
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6267:
--------------------------------
Attachment: hadoop-6267.txt
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6267:
--------------------------------
Status: Patch Available (was: Open)
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757349#action_12757349 ]
Doug Cutting commented on HADOOP-6267:
--------------------------------------
+1 This seems reasonable to me.
Chris, are you vetoing this, or can I commit it?
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757650#action_12757650 ]
Hudson commented on HADOOP-6267:
--------------------------------
Integrated in Hadoop-Common-trunk #102 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/])
. Permit building contrib modules located in external source trees. Contributed by Todd Lipcon.
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756844#action_12756844 ]
Hadoop QA commented on HADOOP-6267:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419939/hadoop-6267.txt
against trunk revision 816398.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/console
This message is automatically generated.
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-6267:
----------------------------------
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
This isn't an Apache build issue.
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting resolved HADOOP-6267.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
I just committed this. Thanks, Todd!
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-6267) build-contrib.xml unnecessarily
enforces that contrib projects be located in contrib/ dir
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reopened HADOOP-6267:
---------------------------------
I disagree. This is simply better ant style, and the technique is a specific example on the ant import task documentation:
http://ant.apache.org/manual/CoreTasks/import.html
Part of the ASF principles and the choice of the Apache license is to encourage outside contributions. While this has no positive (or negative) effect on the project build itself, it makes it easier to develop code that will later be contributed, and encourages that development to be tightly coupled to the existing build process. This means there will be less work later to add it as a contrib/ project, which is good for everyone involved.
Do you have any specific complaints about the patch? If it is zero-sum for the existing codebase but positive for future contributions, it seems to me like it's a net win.
> build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-6267
> URL: https://issues.apache.org/jira/browse/HADOOP-6267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-6267.txt
>
>
> build-contrib.xml currently sets hadoop.root to ${basedir}/../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.