Re: [PR] Bugfix: default case insensitive filters for programmatic and Spring / Spring Boot configurations [shiro]

["steinarb (via GitHub)" <gi...@apache.org>]

steinarb commented on code in PR #2857:
URL: https://github.com/apache/shiro/pull/2857#discussion_r3788595091


##########
core/src/main/java/org/apache/shiro/util/AntPathMatcher.java:
##########
@@ -157,8 +157,7 @@ protected boolean doMatch(String pattern, String path, boolean fullMatch) {
         if (pathIdxStart > pathIdxEnd) {
             // Path is exhausted, only match if rest of pattern is * or **'s
             if (pattIdxStart > pattIdxEnd) {
-                return (pattern.endsWith(this.pathSeparator)
-                        ? path.endsWith(this.pathSeparator) : !path.endsWith(this.pathSeparator));
+                return (pattern.endsWith(this.pathSeparator) == path.endsWith(this.pathSeparator));

Review Comment:
   "ride along" for the bugfix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org