You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/25 14:54:02 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #5338: add support for Neural Networks Menu and runtime
jerpelea opened a new pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338
add support for Neural Network menu andNNabla C Runtime
This is a runtime library for inference Neural Network created
by Neural Network Libraries.
Project git: https://github.com/sony/nnabla-c-runtime
It is almost independent from external libraries(depends on C
standard math library) and is written in Pure C (C99).
It has been developed with priority over readability rather than
performance, making it ideal for learning and porting.
It adopts an extensible architecture, and you can use the function
you implemented yourself as necessary for applications that need performance.
Project license : Apache 2.0 License
https://github.com/sony/nnabla-c-runtime/blob/master/LICENSE
Signed-off-by: Alin Jerpelea <al...@sony.com>
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#issuecomment-1021400495
@jerpelea as you said that want to add more libs, I suggest to take a look on this listing: https://acassis.wordpress.com/2019/01/29/machine-learning-for-microcontrollers/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791843272
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
What's means 'other application'? I suppose that the key decision where is better place for the 3rd party library is who will use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791817942
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
is it a pure userspace library? if that, the better place may be apps/nn/
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
What's means 'other application'? I suppose that the key decision where is better for the 3rd party library is who will use it.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
What's means 'other application'? I suppose that the key decision where is better place for the 3rd party library is who will use it.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from different open source project. The key point is which one(apps/nn and nuttx/nn) is better place.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from different open source project. The key point is which one(apps/nn or nuttx/nn) is better place.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from different open source project. The key point is which one(apps/nn or nuttx/nn) is better place. Here is my thought:
1. If the library will be used by kernel driver, we need to put into nuttx/nn
2. If the library is only used by user space program, apps/nn is more suitable
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
kernel/flat isn't a key point here. All libraries inside apps folder can be enabled and link in kernel mode too.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
kernel/flat isn't a key point here. All libraries inside apps folder can be enabled and link when kernel build is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791922216
##########
File path: Kconfig
##########
@@ -2032,6 +2032,10 @@ menu "Open Asymmetric Multi Processing"
source "openamp/Kconfig"
endmenu
+menu "Neural Network Configuration"
+source "nn/Kconfig"
Review comment:
@jerpelea instead calling it nn I suggest using ai, it will be more clear and we could support others algorithms besides Neural Networks. So nn could be a directory inside ai/
##########
File path: Kconfig
##########
@@ -2032,6 +2032,10 @@ menu "Open Asymmetric Multi Processing"
source "openamp/Kconfig"
endmenu
+menu "Neural Network Configuration"
+source "nn/Kconfig"
Review comment:
@jerpelea instead calling it nn I suggest using ai, it will be more clear and we could support others algorithms beside Neural Networks. So nn could be a directory inside ai/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791817942
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
is it a pure userspace library? if that, the better place may be apps/nn/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#issuecomment-1021949141
moved to apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791852046
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
In this specific case it will be a DNN runtime library that resides in apps folder. My plan was to add several NN libraries that can increase the NN usage with NuttX and help community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791861442
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from different open source project. The key point is which one(apps/nn or nuttx/nn) is better place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791861442
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from different open source project. The key point is which one(apps/nn or nuttx/nn) is better place. Here is my thought:
1. If the library will be used by kernel driver, we need to put into nuttx/nn
2. If the library is only used by user space program, apps/nn is more suitable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791838798
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
the NN libraries should be accessible by other applications so in my opinion they should be in NuttX not Apps
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
I was planning to group all NN libraries in this folder
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
In this specific case it will be a DNN runtime library that resides in apps folder. My plan was to add several NN libraries that can increase the NN usage with NuttX and help community.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
since those libs should be system wide available in both flat and kernel builds I would suggest nuttx/nn
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
I will close the PR. test the move to apps and open a new PR. Thanks for reviewing the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791868792
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
kernel/flat isn't a key point here. All libraries inside apps folder can be enabled and link when kernel build is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea closed pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea closed pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791874895
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
I will close the PR. test the move to apps and open a new PR. Thanks for reviewing the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791841925
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
I was planning to group all NN libraries in this folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791868792
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
kernel/flat isn't a key point here. All libraries inside apps folder can be enabled and link in kernel mode too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791866094
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
since those libs should be system wide available in both flat and kernel builds I would suggest nuttx/nn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r792352722
##########
File path: Kconfig
##########
@@ -2032,6 +2032,10 @@ menu "Open Asymmetric Multi Processing"
source "openamp/Kconfig"
endmenu
+menu "Neural Network Configuration"
+source "nn/Kconfig"
Review comment:
I have ready tensorflow and cmsis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791838798
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
the NN libraries should be accessible by other applications so in my opinion they should be in NuttX not Apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791843272
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
What's means 'other application'? I suppose that the key decision where is better for the 3rd party library is who will use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5338: add support for Neural Networks Menu and runtime
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791861442
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from different open source project. The key point is which one(apps/nn and nuttx/nn) is better place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org