[jira] [Work logged] (CAMEL-14156) JmsBinding assumes endpoint can't be null, but it can

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CAMEL-14156?focusedWorklogId=340573&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340573 ]

ASF GitHub Bot logged work on CAMEL-14156:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Nov/19 15:58
            Start Date: 08/Nov/19 15:58
    Worklog Time Spent: 10m 
      Work Description: jbonofre commented on pull request #3328: [CAMEL-14156] Avoid NPE with endpoint is null in JmsBinding
URL: https://github.com/apache/camel/pull/3328
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 340573)
    Remaining Estimate: 0h
            Time Spent: 10m

> JmsBinding assumes endpoint can't be null, but it can
> -----------------------------------------------------
>
>                 Key: CAMEL-14156
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14156
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-activemq, camel-jms
>    Affects Versions: 2.24.2
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>            Priority: Critical
>             Fix For: 2.24.3, 2.25.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CAMEL-13750 introduces a change checking the {{endpoint}} in {{JmsBinding}}:
> {code}
> if (headerName.equals("JMSCorrelationID") && !endpoint.isUseMessageIDAsCorrelationID()) {
> {code}
> As {{endpoint}} can be null (for instance if you just do {{new JmsBinding()}}), this change is wrong as it can throw {{NullPointerException}}.
> I'm fixing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)