[jira] Updated: (MECLIPSE-213) more jee support for wtp

["Richard van Nieuwenhoven (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MECLIPSE-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard van Nieuwenhoven updated MECLIPSE-213:
----------------------------------------------

    Attachment: maven-eclipse-plugin.patch

re patched for version 2.5-SNAPSHOT

now including an initial test case (i will write more detailed asserts in the next 2 weeks). But because these were a lot of changes, i do not want to do them again on a changed trunk......

my changes in short 
* an IdeDependency now knows the name of the eclipse project if it is in the reactor.
* an IdeDependency now has an equals that supports multiple system dependencies to the same file
* an IdeDependency now knows if a system dependency is outside or inside the reactor
  some work has to be done here how to detect it correctly
* duplicate dependencies (to the same file) are not included in the classpath
* an eclipse application.xml can be generated in a target/eclipseEar directory
  this resolves the problem of wtp including far to mutch in the ear 
* eclipse manifests are written so that they do not interfere with the maven manifest's
  in a extra resource directory not known by maven, i commented out the code
  that uses that standard pexus stuff to generate a manifest because that requires
  a dependency resolution that failes in a lot of tests..
* changed multible places where the getArtifactId() is used instead of getEclipseProjectName()
* the ComponentWriter now uses the deployPath for the ear  plugin definition
* the ComponentWriter will not include jars outside the reactor  in the component 
  (this is specially for dependencies on jars of an application server)

Please report me if the patch has any problems that prohibiting an apply. So that i correct it immediately.
Does anyone has tips for the manifest generation problems?

Ritchie





> more jee support for wtp
> ------------------------
>
>                 Key: MECLIPSE-213
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-213
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: WTP support
>    Affects Versions: 2.3
>         Environment: linux suse 10.0 eclipse 3.2.1 and wtp 1.5.1 java 1.5.0_8
>            Reporter: Richard van Nieuwenhoven
>         Attachments: maven-eclipse-plugin-2.3-CFC-2007-03-08.patch, maven-eclipse-plugin-2.3-PATCH-2007-03-08.tgz, maven-eclipse-plugin-R494407.patch, maven-eclipse-plugin.patch
>
>
> I tried the new release 2.3 of the eclipse plugin and noteted that not alle of my paches where included. 
> I re-pached the 2.3 version again this time i made my changes configurable so they can be turned on and off.
> my changes:
> - prohibit dupicate entries in the classpath
>     provided system paths in combination with log4j/commons-logging/xerces can easely create such problems
> - system paths are only included in ears and war when they are inside the project
>    bether behavior would be to exclude all system paths because the war and ear plugin also ignore these
> - an application.xml specialy for eclipse-wtp 
>    this makes wtp ears function correctly it includes the eclipse project modules instead of the maven generated jars
> - manifest generation for wtp
>    wtp needs manifest files, but not the ones maven creates because they have version names for all modules etc
>    this generates a wtp manifest that will be in a ons eclipse source directory that is ignored my maven itself
> use the parameters  -Declipse.wtpmanifest=true -Declipse.wtpapplicationxml=true  to acivate the patch.
> The manifest generator could be combined with the RadManifestWriter in the future, they are almost the same.
> regards,
> Ritchie

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira