You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/03/25 02:08:05 UTC
[GitHub] [rocketmq] zcsh0721 opened a new pull request #2751: [ISSUE #2750]Remove meaningless code and optimize
zcsh0721 opened a new pull request #2751:
URL: https://github.com/apache/rocketmq/pull/2751
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2751: [ISSUE #2750]Remove meaningless code and optimize
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2751:
URL: https://github.com/apache/rocketmq/pull/2751#issuecomment-806312395
[](https://coveralls.io/builds/38232801)
Coverage increased (+0.03%) to 51.943% when pulling **be996346e1961a4a32666895a0c6f9a8420b559d on zcsh0721:develop** into **46459426801d582b5ef71c8a3e38267ccd6caad9 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zcsh0721 commented on pull request #2751: [ISSUE #2750]Remove meaningless code and optimize
Posted by GitBox <gi...@apache.org>.
zcsh0721 commented on pull request #2751:
URL: https://github.com/apache/rocketmq/pull/2751#issuecomment-818568328
@maixiaohai 你好,我不太清楚我种修改代码的方式该如何写测试用例.
首先我是删除无用代码, 且把代码抽离一部分; 组成了一个`getSuggestPullingFromSlave()` 方法. 且我认为他应该是 `private`.
因为这不是新增加功能和修复 bug . 所以我认为只要通过原来的测试用例即可. 尽管我想编写一些测试用例,但是这种情况我不知道如何下手;
想请教一下............
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org