You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "David Bowen (JIRA)" <ji...@apache.org> on 2009/11/20 04:42:39 UTC
[jira] Created: (SOLR-1579) CLONE -stats.jsp XML escaping
CLONE -stats.jsp XML escaping
-----------------------------
Key: SOLR-1579
URL: https://issues.apache.org/jira/browse/SOLR-1579
Project: Solr
Issue Type: Bug
Components: web gui
Reporter: David Bowen
Assignee: Erik Hatcher
Fix For: 1.4
stats.jsp gave this error:
Line Number 1327, Column 48: <stat name="item_attrFacet_Size_&_Shape"
stat names are not XML escaped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1579) CLONE -stats.jsp XML escaping
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bowen updated SOLR-1579:
------------------------------
Attachment: SOLR-1579.patch
This is a trivial fix, but I'm supplying a patch in the hope of raising the priority.
> CLONE -stats.jsp XML escaping
> -----------------------------
>
> Key: SOLR-1579
> URL: https://issues.apache.org/jira/browse/SOLR-1579
> Project: Solr
> Issue Type: Bug
> Components: web gui
> Affects Versions: 1.4
> Reporter: David Bowen
> Assignee: Erik Hatcher
> Fix For: 1.5
>
> Attachments: SOLR-1579.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The fix to SOLR-1008 was wrong. It used chardata escaping for a value that is an attribute value.
> I.e. instead of XML.escapeCharData it should call XML.escapeAttributeValue.
> Otherwise, any query used as a key in the filter cache whose printed representation contains a double-quote character causes invalid XML to be generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1579) CLONE -stats.jsp XML escaping
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-1579.
----------------------------
Resolution: Fixed
Assignee: Hoss Man (was: Erik Hatcher)
I fully expect stats.jsp will be deprecated in the next release of Solr in favor of the handler in SOLR-1750 -- BUT -- I still can't beleive such an anoying and yet trivial to fix bug was arround for so long ... especially since the incorrect fix for the XML attribute escaping is only half the problem: escapeCharData as still needed for the XML ELement content escaping.
David: thanks for your prodding on this ... i committed your patch plus some additional fixes (r909705)
> CLONE -stats.jsp XML escaping
> -----------------------------
>
> Key: SOLR-1579
> URL: https://issues.apache.org/jira/browse/SOLR-1579
> Project: Solr
> Issue Type: Bug
> Components: web gui
> Affects Versions: 1.4
> Reporter: David Bowen
> Assignee: Hoss Man
> Fix For: 1.5
>
> Attachments: SOLR-1579.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The fix to SOLR-1008 was wrong. It used chardata escaping for a value that is an attribute value.
> I.e. instead of XML.escapeCharData it should call XML.escapeAttributeValue.
> Otherwise, any query used as a key in the filter cache whose printed representation contains a double-quote character causes invalid XML to be generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1579) CLONE -stats.jsp XML escaping
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-1579:
------------------------------
Fix Version/s: (was: 1.4)
1.5
> CLONE -stats.jsp XML escaping
> -----------------------------
>
> Key: SOLR-1579
> URL: https://issues.apache.org/jira/browse/SOLR-1579
> Project: Solr
> Issue Type: Bug
> Components: web gui
> Affects Versions: 1.4
> Reporter: David Bowen
> Assignee: Erik Hatcher
> Fix For: 1.5
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The fix to SOLR-1008 was wrong. It used chardata escaping for a value that is an attribute value.
> I.e. instead of XML.escapeCharData it should call XML.escapeAttributeValue.
> Otherwise, any query used as a key in the filter cache whose printed representation contains a double-quote character causes invalid XML to be generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1579) CLONE -stats.jsp XML escaping
Posted by "David Bowen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Bowen updated SOLR-1579:
------------------------------
Description:
The fix to SOLR-1008 was wrong. It used chardata escaping for a value that is an attribute value.
I.e. instead of XML.escapeCharData it should call XML.escapeAttributeValue.
Otherwise, any query used as a key in the filter cache whose printed representation contains a double-quote character causes invalid XML to be generated.
was:
stats.jsp gave this error:
Line Number 1327, Column 48: <stat name="item_attrFacet_Size_&_Shape"
stat names are not XML escaped.
Affects Version/s: 1.4
> CLONE -stats.jsp XML escaping
> -----------------------------
>
> Key: SOLR-1579
> URL: https://issues.apache.org/jira/browse/SOLR-1579
> Project: Solr
> Issue Type: Bug
> Components: web gui
> Affects Versions: 1.4
> Reporter: David Bowen
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The fix to SOLR-1008 was wrong. It used chardata escaping for a value that is an attribute value.
> I.e. instead of XML.escapeCharData it should call XML.escapeAttributeValue.
> Otherwise, any query used as a key in the filter cache whose printed representation contains a double-quote character causes invalid XML to be generated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.