You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "detelin20@yahoo.com (JIRA)" <ji...@apache.org> on 2012/07/12 17:14:33 UTC
[jira] [Created] (AXIOM-432) Updating the last child is not correct
unless we are replacing the last child
detelin20@yahoo.com created AXIOM-432:
-----------------------------------------
Summary: Updating the last child is not correct unless we are replacing the last child
Key: AXIOM-432
URL: https://issues.apache.org/jira/browse/AXIOM-432
Project: Axiom
Issue Type: Bug
Components: DOOM
Reporter: detelin20@yahoo.com
I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
But when it is converted into the OOM model some of the headers disappear.
soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
then the lastChild should point to HDR3; instead it points to HDR2
so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456127#comment-13456127 ]
Hudson commented on AXIOM-432:
------------------------------
Integrated in ws-axiom-trunk #1214 (See [https://builds.apache.org/job/ws-axiom-trunk/1214/])
AXIOM-432: Added more test cases and assertions for Node#replaceChild and fixed several issues. (Revision 1384874)
Result = SUCCESS
veithen :
Files :
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/ReplaceChildTestCase.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirst.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirstWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildLast.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildLastWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildMiddle.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildMiddleWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildSingle.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/OMDOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildFirstIncomplete.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildIncomplete.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildMiddleIncomplete.java
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Assignee: Andreas Veithen
> Fix For: 1.2.14
>
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "detelin20@yahoo.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415998#comment-13415998 ]
detelin20@yahoo.com commented on AXIOM-432:
-------------------------------------------
Yes I'm sure for axiom-1.2.7 and it should be reproducible with test example attached here.
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415471#comment-13415471 ]
Andreas Veithen commented on AXIOM-432:
---------------------------------------
Are you sure about the Axiom version? I see a different instruction at line 414 in the ParentNode code from version 1.2.7 [1].
[1] https://svn.apache.org/repos/asf/webservices/commons/tags/axiom/1.2.7/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415982#comment-13415982 ]
Andreas Veithen commented on AXIOM-432:
---------------------------------------
Line 414 is in a code path that is executed only if the new child is a DocumentFragment. Are you sure that WSS4J is manipulating a DocumentFragment here?
I fixed one issue in replaceChild, but this is in a different code path.
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421726#comment-13421726 ]
Andreas Veithen commented on AXIOM-432:
---------------------------------------
Can you provide some instructions about how to run the sample?
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Updated] (AXIOM-432) Updating the last child is not correct
unless we are replacing the last child
Posted by "detelin20@yahoo.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
detelin20@yahoo.com updated AXIOM-432:
--------------------------------------
Attachment: axiom432-test.zip
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Work started] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on AXIOM-432 started by Andreas Veithen.
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Assignee: Andreas Veithen
> Fix For: 1.2.14
>
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416036#comment-13416036 ]
Hudson commented on AXIOM-432:
------------------------------
Integrated in ws-axiom-trunk #1109 (See [https://builds.apache.org/job/ws-axiom-trunk/1109/])
AXIOM-432: Increased test coverage of ParentNode#replaceChild. (Revision 1362402)
Result = SUCCESS
veithen :
Files :
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChild.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirst.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildNotFound.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildNullNewChild.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildSingle.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildWithAncestor.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415509#comment-13415509 ]
Hudson commented on AXIOM-432:
------------------------------
Integrated in ws-axiom-trunk #1106 (See [https://builds.apache.org/job/ws-axiom-trunk/1106/])
Fixed an issue in ParentNode#replaceChild that looks like AXIOM-432. (Revision 1362171)
Result = SUCCESS
veithen :
Files :
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/OMDOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/omdom/element/TestReplaceChildIncomplete.java
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "detelin20@yahoo.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415966#comment-13415966 ]
detelin20@yahoo.com commented on AXIOM-432:
-------------------------------------------
I meant line 414 in 1.2.13. Is the defect resolved now or not?
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Assigned] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen reassigned AXIOM-432:
-------------------------------------
Assignee: Andreas Veithen
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Assignee: Andreas Veithen
> Fix For: 1.2.14
>
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "detelin20@yahoo.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414977#comment-13414977 ]
detelin20@yahoo.com commented on AXIOM-432:
-------------------------------------------
I attached the test case in the issue.
You will need axis2, and rampart to execute the example. Notice that after decrypting the custom "hdr1:HeaderLocal_1" header, "wsa:Action" header goes missing and Rampart's validation fails.
There are client and service. This defect was found in version 1.2.7. Since the ParentNode is not changed a lot it should appear in the latest release as well.
It apples at line 414 this.lastChild = (ChildNode)docFrag.getLastChild()
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Resolved] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIOM-432.
-----------------------------------
Resolution: Fixed
The reporter didn't provide the necessary instructions to execute the sample that is expected to show the issue. Nevertheless I believe that the issue is fixed: multiple problems in the implementation of the replaceChild method were found and have been corrected.
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Assignee: Andreas Veithen
> Fix For: 1.2.14
>
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416412#comment-13416412 ]
Hudson commented on AXIOM-432:
------------------------------
Integrated in ws-axiom-trunk #1110 (See [https://builds.apache.org/job/ws-axiom-trunk/1110/])
AXIOM-432: Further increased the test coverage of ParentNode#replaceChild and fixed a couple of issues that occur when newChild is a document fragment. (Revision 1362582)
Result = SUCCESS
veithen :
Files :
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestInsertBeforeWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChild.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildCyclic.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirst.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildFirstWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildLast.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildLastWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildMiddle.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildMiddleWithDocumentFragment.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestReplaceChildWithAncestor.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ParentNode.java
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (AXIOM-432) Updating the last child is not
correct unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413002#comment-13413002 ]
Andreas Veithen commented on AXIOM-432:
---------------------------------------
Do you have a test case to reproduce the issue?
Can you specify the Axiom version with which the issue occurs (and to which the line number in ParentNode applies)?
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Updated] (AXIOM-432) Updating the last child is not correct
unless we are replacing the last child
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIOM-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen updated AXIOM-432:
----------------------------------
Fix Version/s: 1.2.14
> Updating the last child is not correct unless we are replacing the last child
> -----------------------------------------------------------------------------
>
> Key: AXIOM-432
> URL: https://issues.apache.org/jira/browse/AXIOM-432
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Reporter: detelin20@yahoo.com
> Fix For: 1.2.14
>
> Attachments: axiom432-test.zip
>
>
> I have a simple policy which encrypts a header. When the WSS for J decrypts I could see in the Dom model the decrypted header. Actually I have 3 headers of which one is encrypted in the Dom model. I see all the 3 headers after it is decrypted.
> But when it is converted into the OOM model some of the headers disappear.
> soapHeader.addHeaderBlock(element.getLocalName(), element.getNamespace()); statement
> I noticed that the lastChild field of the SOAPHeader block points to a header element somewhere in the middle of the list instead of the last one
> meaning if the Header block contains 3 headers HDR1 -> HDR2 -> HDR3
> then the lastChild should point to HDR3; instead it points to HDR2
> so when a new header HDR4 is added, instead of the list becoming HDR1 -> HDR2 -> HDR3 -> HDR4
> it becomes HDR1 -> HDR2 -> HDR4 skipping HDR3
> The defect is in org.apache.axiom.om.impl.dom.ParentNode.replaceChild(Node, Node) ,line 414, where
> updating the last child is not correct unless we are replacing the last child.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org