You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/28 22:45:10 UTC
[GitHub] [solr] dsmiley opened a new pull request #52: SOLR-15283 GlobalTracer overhaul
dsmiley opened a new pull request #52:
URL: https://github.com/apache/solr/pull/52
https://issues.apache.org/jira/browse/SOLR-15283
(for overall concerns, discuss in JIRA)
* Solr's GlobalTracer is gone. Use OpenTracing's GlobalTracer, or even better: getters on CoreContainer, SolrQueryRequest, etc.
* No more "samplingThreshold" cluster property. Instead, configure sampling specific to the plugin.
* Ensure the active span is visible from all threads by using ExecutorUtil
TODO:
* Solr Ref Guide
* CHANGES / upgrade notes
* JaegerTracerConfigurator's sampler should be configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #52: SOLR-15283 GlobalTracer overhaul
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #52:
URL: https://github.com/apache/solr/pull/52#issuecomment-819812964
I think this is ready; I'll merge it Friday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ryo0301 commented on pull request #52: SOLR-15283 GlobalTracer overhaul
Posted by GitBox <gi...@apache.org>.
ryo0301 commented on pull request #52:
URL: https://github.com/apache/solr/pull/52#issuecomment-826294526
The ticket number in CHANGES.txt is SOLR-15238, not SOLR-15283.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #52: SOLR-15283 GlobalTracer overhaul
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #52:
URL: https://github.com/apache/solr/pull/52#issuecomment-826326585
Thanks @ryo0301 ; I pushed a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #52: SOLR-15283 GlobalTracer overhaul
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #52:
URL: https://github.com/apache/solr/pull/52#issuecomment-826326585
Thanks @ryo0301 ; I pushed a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ryo0301 commented on pull request #52: SOLR-15283 GlobalTracer overhaul
Posted by GitBox <gi...@apache.org>.
ryo0301 commented on pull request #52:
URL: https://github.com/apache/solr/pull/52#issuecomment-826294526
The ticket number in CHANGES.txt is SOLR-15238, not SOLR-15283.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #52: SOLR-15283 GlobalTracer overhaul
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #52:
URL: https://github.com/apache/solr/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org