[GitHub] [camel-quarkus] essobedo commented on a diff in pull request #5380: feat(native): support Native Sources

["essobedo (via GitHub)" <gi...@apache.org>]

essobedo commented on code in PR #5380:
URL: https://github.com/apache/camel-quarkus/pull/5380#discussion_r1341154370


##########
extensions-jvm/asn1/deployment/src/main/java/org/apache/camel/quarkus/component/asn1/deployment/Asn1Processor.java:
##########
@@ -37,7 +37,7 @@ FeatureBuildItem feature() {
     /**
      * Remove this once this extension starts supporting the native mode.
      */
-    @BuildStep(onlyIf = NativeBuild.class)
+    @BuildStep(onlyIf = NativeOrNativeSourcesBuild.class)
     @Record(value = ExecutionTime.RUNTIME_INIT)
     void warnJvmInNative(JvmOnlyRecorder recorder) {

Review Comment:
   In case of warnings like here, it could remain `NativeBuild` but for the sake of uniformity, I understand that it is changed for `NativeOrNativeSourcesBuild`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org