You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/10/28 21:57:03 UTC
Review Request 27309: Make executor overhead configurable via CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-830
https://issues.apache.org/jira/browse/AURORA-830
Repository: aurora
Description
-------
Make executor overhead configurable via CLI.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
Diff: https://reviews.apache.org/r/27309/diff/
Testing
-------
./gradlew clean build -Pq
Thanks,
Zameer Manji
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58867
-----------------------------------------------------------
Master (a518053) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
- Aurora ReviewBot
On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Zameer Manji <zm...@twopensource.com>.
> On Oct. 28, 2014, 3:14 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36
> > <https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36>
> >
> > Is there a jira w/ more context? If not can there be? It's not clear to me from looking at this why this should be removed and what it should be replaced with.
>
> Bill Farner wrote:
> Ah - yes, this should contain a reference to a ticket that's part of the yet-to-be-created deprecations epic for 0.8.0. Can you create the 0.8.0 ticket chain?
>
> 0.8.0 release candidate (e.g. AURORA-872) blocked by 0.8.0 deprecations epic (e.g. AURORA-423) containing this new ticket.
>
> Zameer Manji wrote:
> Who is that 'you' directed to?
>
> Joshua Cohen wrote:
> Heh, I had assumed it was directed at you since it would involve updating the TODO to point to the ticket once created?
I'm on it.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58897
-----------------------------------------------------------
On Oct. 28, 2014, 1:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 1:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Bill Farner <wf...@apache.org>.
> On Oct. 28, 2014, 10:14 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36
> > <https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36>
> >
> > Is there a jira w/ more context? If not can there be? It's not clear to me from looking at this why this should be removed and what it should be replaced with.
Ah - yes, this should contain a reference to a ticket that's part of the yet-to-be-created deprecations epic for 0.8.0. Can you create the 0.8.0 ticket chain?
0.8.0 release candidate (e.g. AURORA-872) blocked by 0.8.0 deprecations epic (e.g. AURORA-423) containing this new ticket.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58897
-----------------------------------------------------------
On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Zameer Manji <zm...@twopensource.com>.
> On Oct. 28, 2014, 3:14 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36
> > <https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36>
> >
> > Is there a jira w/ more context? If not can there be? It's not clear to me from looking at this why this should be removed and what it should be replaced with.
>
> Bill Farner wrote:
> Ah - yes, this should contain a reference to a ticket that's part of the yet-to-be-created deprecations epic for 0.8.0. Can you create the 0.8.0 ticket chain?
>
> 0.8.0 release candidate (e.g. AURORA-872) blocked by 0.8.0 deprecations epic (e.g. AURORA-423) containing this new ticket.
Who is that 'you' directed to?
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58897
-----------------------------------------------------------
On Oct. 28, 2014, 1:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 1:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Oct. 28, 2014, 10:14 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36
> > <https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36>
> >
> > Is there a jira w/ more context? If not can there be? It's not clear to me from looking at this why this should be removed and what it should be replaced with.
>
> Bill Farner wrote:
> Ah - yes, this should contain a reference to a ticket that's part of the yet-to-be-created deprecations epic for 0.8.0. Can you create the 0.8.0 ticket chain?
>
> 0.8.0 release candidate (e.g. AURORA-872) blocked by 0.8.0 deprecations epic (e.g. AURORA-423) containing this new ticket.
>
> Zameer Manji wrote:
> Who is that 'you' directed to?
Heh, I had assumed it was directed at you since it would involve updating the TODO to point to the ticket once created?
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58897
-----------------------------------------------------------
On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58897
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java
<https://reviews.apache.org/r/27309/#comment100059>
Is there a jira w/ more context? If not can there be? It's not clear to me from looking at this why this should be removed and what it should be replaced with.
- Joshua Cohen
On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review58896
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 8:57 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review59039
-----------------------------------------------------------
Ship it!
Master (978998a) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Oct. 29, 2014, 7:54 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 7:54 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review59044
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Oct. 29, 2014, 7:54 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 7:54 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/#review59051
-----------------------------------------------------------
Ship it!
This is now on master
$ git log -1 origin/master --abbrev-commit
commit 6b30cf7
Author: Zameer Manji <zm...@twopensource.com>
Date: Wed Oct 29 14:56:43 2014 -0700
Make executor overhead configurable via CLI.
Bugs closed: AURORA-830
Reviewed at https://reviews.apache.org/r/27309/
- Bill Farner
On Oct. 29, 2014, 7:54 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27309/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 7:54 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make executor overhead configurable via CLI.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
> src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
>
> Diff: https://reviews.apache.org/r/27309/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 27309: Make executor overhead configurable via CLI.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27309/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 12:54 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Add ticket to track ResourceSlot removal.
Bugs: AURORA-830
https://issues.apache.org/jira/browse/AURORA-830
Repository: aurora
Description
-------
Make executor overhead configurable via CLI.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f
src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594
Diff: https://reviews.apache.org/r/27309/diff/
Testing
-------
./gradlew clean build -Pq
Thanks,
Zameer Manji