You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by un...@apache.org on 2004/03/05 16:05:02 UTC
cvs commit: cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/store JCSStore.java
unico 2004/03/05 07:05:02
Modified: src/blocks/scratchpad/java/org/apache/cocoon/components/store
JCSStore.java
Log:
clean up logging and add some TODOs
Revision Changes Path
1.3 +19 -25 cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/store/JCSStore.java
Index: JCSStore.java
===================================================================
RCS file: /home/cvs/cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/store/JCSStore.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- JCSStore.java 5 Mar 2004 10:07:26 -0000 1.2
+++ JCSStore.java 5 Mar 2004 15:05:02 -0000 1.3
@@ -93,7 +93,10 @@
* <code>group-name</code>: the group to be used as defined in the config file
* </li>
* </ul>
- *
+ *
+ * TODO: instead of loading properties from an external file we may want to
+ * specify them using parameters.
+ *
* @param params the configuration paramters
* @exception ParameterException
*/
@@ -101,6 +104,7 @@
// TODO - These are only values for testing:
String configFile = params.getParameter("config-file", "context://WEB-INF/cache.ccf");
m_region = params.getParameter("region-name", "indexedRegion1");
+ // FIXME: I don't think group-name is really required here
m_group = params.getParameter("group-name", "indexedDiskCache");
if (this.getLogger().isDebugEnabled()) {
@@ -188,10 +192,7 @@
if (getLogger().isDebugEnabled())
{
- getLogger().debug("store(): Store file with key: "
- + key.toString());
- getLogger().debug("store(): Store file with value: "
- + value.toString());
+ getLogger().debug("Store object " + value + " with key "+ key);
}
//This test is not really pertinent here - we
@@ -204,7 +205,7 @@
}
catch (CacheException ce)
{
- getLogger().error("store(..): Exception", ce);
+ getLogger().error("Failure storing object ", ce);
}
}
else
@@ -215,15 +216,7 @@
/**
* Frees some values of the data file.<br>
- * TODO: implementation
- */
- public void free()
- {
- // if we ever implement this, we should implement doFree()
- }
-
- /* (non-Javadoc)
- * @see org.apache.excalibur.store.impl.AbstractReadWriteStore#doFree()
+ * TODO: implementation?
*/
protected void doFree() {
}
@@ -236,7 +229,7 @@
if (getLogger().isDebugEnabled())
{
- getLogger().debug("clear(): Clearing the database ");
+ getLogger().debug("Clearing the store");
}
try
@@ -248,7 +241,7 @@
}
catch (CacheException ce)
{
- getLogger().error("store(..): Exception", ce);
+ getLogger().error("Failure clearing store", ce);
}
}
@@ -261,18 +254,17 @@
{
if (getLogger().isDebugEnabled())
{
- getLogger().debug("remove(..) Remove item");
+ getLogger().debug("Removing item " + key);
}
try
{
- m_JCS.remove(key);
- }
- //Need to revisit this exception - what happens
- //if no match found for key - is an exception thrown?
- catch (CacheException ce)
+ m_JCS.remove(key);
+ }
+ // if object for key does no exists exception is thrown
+ catch (CacheException ce)
{
- getLogger().error("remove(..): Exception", ce);
+ getLogger().error("Failure removing object", ce);
}
}
@@ -284,7 +276,7 @@
*/
protected boolean doContainsKey(Object key)
{
-
+
//All we have available is a null check
if (m_JCS.get(key) != null) {
return true;
@@ -301,6 +293,8 @@
* needs to be passed in as a string in this way - we should
* be able to retreive it.
* FIX ME!!
+ *
+ * UH: I think an empty String would be the correct value for the group?
*
* @return Enumeration Object with all existing keys
*/
Re: cvs commit: cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/store
JCSStore.java
Posted by Reinhard Pötz <re...@apache.org>.
unico@apache.org wrote:
>unico 2004/03/05 07:05:02
>
> Modified: src/blocks/scratchpad/java/org/apache/cocoon/components/store
> JCSStore.java
> Log:
> clean up logging and add some TODOs
>
> Revision Changes Path
> 1.3 +19 -25 cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/store/JCSStore.java
>
> Index: JCSStore.java
> ===================================================================
> RCS file: /home/cvs/cocoon-2.1/src/blocks/scratchpad/java/org/apache/cocoon/components/store/JCSStore.java,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- JCSStore.java 5 Mar 2004 10:07:26 -0000 1.2
> +++ JCSStore.java 5 Mar 2004 15:05:02 -0000 1.3
> @@ -93,7 +93,10 @@
> * <code>group-name</code>: the group to be used as defined in the config file
> * </li>
> * </ul>
> - *
> + *
> + * TODO: instead of loading properties from an external file we may want to
> + * specify them using parameters.
>
>
>
This would be fine (I don't like it if we have so many configuration
files around ... cocoon.xconf, logkit.xconf, ojb.properties is enough)
--
Reinhard