[GitHub] [felix-dev] tjwatson commented on a change in pull request #131: FELIX-6511: Cancel the SCR Component Registry's changeCountTimer on deactivation.

[GitBox <gi...@apache.org>]

tjwatson commented on a change in pull request #131:
URL: https://github.com/apache/felix-dev/pull/131#discussion_r824723254



##########
File path: scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java
##########
@@ -732,7 +732,7 @@ public void updateChangeCount()
             final Timer timer;
             synchronized ( this.changeCountTimerLock ) {
                 if ( this.changeCountTimer == null ) {
-                    this.changeCountTimer = new Timer();
+                    this.changeCountTimer = new Timer("SCR Component Registry");

Review comment:
       Should we also make the `Timer` use a daemon thread here by passing true?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org