You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/06/25 20:34:39 UTC

[GitHub] kasjer commented on a change in pull request #1219: Battery Shell

kasjer commented on a change in pull request #1219: Battery Shell
URL: https://github.com/apache/mynewt-core/pull/1219#discussion_r197932836
 
 

 ##########
 File path: hw/drivers/bq27z561/src/bq27z561.c
 ##########
 @@ -663,6 +663,7 @@ bq27z561_battery_property_get(struct battery_driver *driver,
         rc = -1;
         assert(0);
     }
+    property->bp_valid = rc == 0;
 
 Review comment:
   I will change accordingly it and merge if there no more doubts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services