You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2016/01/08 13:19:00 UTC
[GitHub] incubator-brooklyn pull request: Expose BrooklynFeatureEnablement....
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1134
Expose BrooklynFeatureEnablement.setDefault
I want the activation of [brooklyn-tosca](https://github.com/cloudsoft/brooklyn-tosca/) to be configurable and to be enabled by default. At the moment any property beginning `brooklyn.experimental.feature` that is not defined in `BrooklynFeatureEnablement` defaults to `false` (because `Boolean.parseBoolean(null) == false`). This change allows downstream projects to explicitly configure defaults.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn feature-default
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1134
----
commit 8b486f54b3bcbed8e5507dfbc1a68b3c60340615
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2016-01-08T12:01:11Z
Expose BrooklynFeatureEnablement.setDefault
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Expose BrooklynFeatureEnablement....
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1134#issuecomment-170010680
Looks sensible; merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Expose BrooklynFeatureEnablement....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---