You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2020/07/21 01:00:49 UTC
[GitHub] [jackrabbit-oak] dlh3 opened a new pull request #242: OAK-9145: Swap order of default filters
dlh3 opened a new pull request #242:
URL: https://github.com/apache/jackrabbit-oak/pull/242
WordDelimiterFilter is invoked with the GENERATE_WORD_PARTS flag, which splits camelCase/PascalCase into multiple terms. But since the LowerCaseFilter is applied first, the mixed-case is lost and the terms can't be split by WordDelimiterFilter. Reversing filters so that behaviour occurs as expected.
I would have liked to add unit tests, but there didn't seem to be any around this class. I *may* come back to add some.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] dlh3 commented on pull request #242: OAK-9145: Swap order of default filters
Posted by GitBox <gi...@apache.org>.
dlh3 commented on pull request #242:
URL: https://github.com/apache/jackrabbit-oak/pull/242#issuecomment-662651623
I have made several attempts to add unit tests for this, but I'm really struggling to figure out how to add a fulltext test which uses an index with OakAnalyzer. It would be awesome if somebody else in the community helped out with the unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on pull request #242: OAK-9145: Swap order of default filters
Posted by GitBox <gi...@apache.org>.
mreutegg commented on pull request #242:
URL: https://github.com/apache/jackrabbit-oak/pull/242#issuecomment-868269657
JIRA issue was resolved WONTFIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg closed pull request #242: OAK-9145: Swap order of default filters
Posted by GitBox <gi...@apache.org>.
mreutegg closed pull request #242:
URL: https://github.com/apache/jackrabbit-oak/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org