[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8074: sem: Remove PRIOINHERIT_FLAGS_ENABLE and use SEM_PRIO_INHERIT instead

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8074:
URL: https://github.com/apache/nuttx/pull/8074#discussion_r1066826141


##########
sched/semaphore/sem_setprotocol.c:
##########
@@ -103,10 +96,11 @@ int nxsem_set_protocol(FAR sem_t *sem, int protocol)
         return -ENOTSUP;
 
       default:
-        break;
+        return -EINVAL;
     }
 
-  return -EINVAL;
+  sem->flags = protocol;

Review Comment:
   It intends to not mask protocol with SEM_PRIO_MASK, since the upcoming patch will add a new flag:
   ```
   #define SEM_USAGE_MUTEX 0x04
   ```
   and the caller(mutex) can change the usage from sem to mutex explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org