You are viewing a plain text version of this content. The canonical link for it is here.
Posted to distributedlog-dev@bookkeeper.apache.org by franckcuny <gi...@git.apache.org> on 2016/07/25 16:08:23 UTC
[GitHub] incubator-distributedlog pull request #2: Add NOTICE file.
GitHub user franckcuny opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/2
Add NOTICE file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franckcuny/incubator-distributedlog fcuny/DL-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 04576d7a75e8d96072ae09c1d244ab10b5878a5e
Author: Franck Cuny <fc...@apache.org>
Date: 2016-07-25T02:50:10Z
Add NOTICE file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog pull request #2: DL-4: Add NOTICE file.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #2: Add NOTICE file.
Posted by fpj <gi...@git.apache.org>.
Github user fpj commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/2
@franckcuny you may have seen this already, but just in case you may want to have a look at the instructions here:
http://www.apache.org/dev/licensing-howto.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #2: DL-4: Add NOTICE file.
Posted by fpj <gi...@git.apache.org>.
Github user fpj commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/2
@franckcuny @sijie It looks good, but I haven't done an inspection of dependencies and such to determine whether we have anything we need to add to the notice file. That's main reason why I shared the link above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #2: DL-4: Add NOTICE file.
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/2
The notice file looks good to me. +1.
@fpj did you see any problem here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #2: DL-4: Add NOTICE file.
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/2
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---