You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mroz45 (via GitHub)" <gi...@apache.org> on 2024/10/30 10:30:51 UTC
[PR] GH-${44526}: [${C++}] ${Fix crash when thread in asof_join is not running} [arrow]
mroz45 opened a new pull request, #44584:
URL: https://github.com/apache/arrow/pull/44584
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
I add checking joinable before join process_thread. It will prevent exeptions in case when plan is invalid and asof_join never_starts.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2469375907
> @zanmato1984 Could you use our merge script [`main`/dev#how-to-merge-a-pull-request](https://github.com/apache/arrow/tree/main/dev#how-to-merge-a-pull-request) next time? It removes comments (`<!-- ... -->`) from PR description and use the prepared PR description as a commit message.
Thank you for reminding, I'll read the instruction and use it next time. And sorry for the trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 merged PR #44584:
URL: https://github.com/apache/arrow/pull/44584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2469317359
@zanmato1984 Could you use our merge script https://github.com/apache/arrow/tree/main/dev#how-to-merge-a-pull-request next time? It removes comments (`<!-- ... -->`) from PR description and use the prepared PR description as a commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1830583374
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1732,5 +1732,37 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
+// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
+// a sink that fails on creation.
+TEST(AsofJoinTest, DetroyNotStartedAsofJoinNode) {
+ auto left_batch = ExecBatchFromJSON({int64()}, R"([[1], [2], [3]])");
+ auto right_batch =
+ ExecBatchFromJSON({utf8(), int64()}, R"([["Z", 2], ["B", 3], ["A", 4]])");
+
+ Declaration left{"exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("on", int64())}),
+ {std::move(left_batch)})};
+ Declaration right{
+ "exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("colVals", utf8()), field("on", int64())}),
+ {std::move(right_batch)})};
+ AsofJoinNodeOptions asof_join_opts({{{"on"}, {}}, {{"on"}, {}}}, 1);
+ Declaration asof_join{
+ "asofjoin", {std::move(left), std::move(right)}, std::move(asof_join_opts)};
+
+ // Setting invalid arguments, such as nullptr in generator or schema in SinkNodeOptions,
+ // causes the execution plan to terminate before the asofjoin node is started.
+ arrow::acero::SinkNodeOptions sink_node_options{/*generator=*/nullptr,
+ /*schema*/ nullptr};
Review Comment:
```suggestion
/*schema=*/nullptr};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "mroz45 (via GitHub)" <gi...@apache.org>.
mroz45 commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1830615432
##########
.gitignore:
##########
@@ -108,3 +108,10 @@ java/.mvn/.develocity/
# rat
filtered_rat.txt
rat.txt
+
+/a
+/cpp/build_test/
+/cpp/src/arrow/util/config.h
+/cpp/src/parquet/parquet_version.h
+/pyarrow-dev/
+/python/myenv/
Review Comment:
My mistake i will correct it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1824857433
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1731,6 +1731,33 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
ExecBatchFromJSON({int64(), utf8()}, R"([[1, "Z"], [2, "Z"], [3, "B"]])");
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
+// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
Review Comment:
```suggestion
// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
```
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1731,6 +1731,33 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
ExecBatchFromJSON({int64(), utf8()}, R"([[1, "Z"], [2, "Z"], [3, "B"]])");
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
+// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
+// a sink that fails on creation
+TEST(AsofJoinTest, DetroyNotStartedAsofJoinNode) {
+ auto left_batch = ExecBatchFromJSON({int64()}, R"([[1], [2], [3]])");
+ auto right_batch =
+ ExecBatchFromJSON({utf8(), int64()}, R"([["Z", 2], ["B", 3], ["A", 4]])");
+
+ Declaration left{"exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("on", int64())}),
+ {std::move(left_batch)})};
+ Declaration right{
+ "exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("colVals", utf8()), field("on", int64())}),
+ {std::move(right_batch)})};
+ AsofJoinNodeOptions asof_join_opts({{{"on"}, {}}, {{"on"}, {}}}, 1);
+ Declaration asof_join{
+ "asofjoin", {std::move(left), std::move(right)}, std::move(asof_join_opts)};
+ arrow::acero::SinkNodeOptions sink_node_options{nullptr, nullptr};
+ arrow::acero::Declaration sink =
+ arrow::acero::Declaration::Sequence({asof_join, {"sink", sink_node_options}});
+
+ EXPECT_RAISES_WITH_MESSAGE_THAT(
+ Invalid,
+ ::testing::HasSubstr(
+ "`generator` is a required SinkNode option and cannot be null"),
+ DeclarationToStatus(std::move(sink)));
+}
Review Comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1830585386
##########
.gitignore:
##########
@@ -108,3 +108,10 @@ java/.mvn/.develocity/
# rat
filtered_rat.txt
rat.txt
+
+/a
+/cpp/build_test/
+/cpp/src/arrow/util/config.h
+/cpp/src/parquet/parquet_version.h
+/pyarrow-dev/
+/python/myenv/
Review Comment:
Can we not include such changes unless absolutely necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1825712880
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1731,6 +1731,33 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
ExecBatchFromJSON({int64(), utf8()}, R"([[1, "Z"], [2, "Z"], [3, "B"]])");
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
+// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
+// a sink that fails on creation
+TEST(AsofJoinTest, DetroyNotStartedAsofJoinNode) {
+ auto left_batch = ExecBatchFromJSON({int64()}, R"([[1], [2], [3]])");
+ auto right_batch =
+ ExecBatchFromJSON({utf8(), int64()}, R"([["Z", 2], ["B", 3], ["A", 4]])");
+
+ Declaration left{"exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("on", int64())}),
+ {std::move(left_batch)})};
+ Declaration right{
+ "exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("colVals", utf8()), field("on", int64())}),
+ {std::move(right_batch)})};
+ AsofJoinNodeOptions asof_join_opts({{{"on"}, {}}, {{"on"}, {}}}, 1);
+ Declaration asof_join{
+ "asofjoin", {std::move(left), std::move(right)}, std::move(asof_join_opts)};
+ arrow::acero::SinkNodeOptions sink_node_options{nullptr, nullptr};
Review Comment:
Could you add: 1) parameter name (e.g. `/*xxx=*/nullptr, /*xxx=*/nullptr`), 2) some comments about how this intentionally invalid `nullptr` is essential for the reproduction of the targeting bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1834606873
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1732,5 +1732,36 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
+// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
+// a sink that fails on creation
+TEST(AsofJoinTest, DetroyNotStartedAsofJoinNode) {
Review Comment:
```suggestion
TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2468528648
Merged. Thank you @mroz45 for fixing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "mroz45 (via GitHub)" <gi...@apache.org>.
mroz45 commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2449736328
@zanmato1984
Do you think this test is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-${44526}: [${C++}] ${Fix crash when thread in asof_join is not running} [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2446495317
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44584:
URL: https://github.com/apache/arrow/pull/44584#discussion_r1830744719
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1732,5 +1732,37 @@ TEST(AsofJoinTest, RhsEmptinessRaceEmptyBy) {
AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}
+// Reproduction of GH-44526: Provoke destruction of not started asofjoin node by providing
+// a sink that fails on creation
+TEST(AsofJoinTest, DetroyNotStartedAsofJoinNode) {
+ auto left_batch = ExecBatchFromJSON({int64()}, R"([[1], [2], [3]])");
+ auto right_batch =
+ ExecBatchFromJSON({utf8(), int64()}, R"([["Z", 2], ["B", 3], ["A", 4]])");
+
+ Declaration left{"exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("on", int64())}),
+ {std::move(left_batch)})};
+ Declaration right{
+ "exec_batch_source",
+ ExecBatchSourceNodeOptions(schema({field("colVals", utf8()), field("on", int64())}),
+ {std::move(right_batch)})};
+ AsofJoinNodeOptions asof_join_opts({{{"on"}, {}}, {{"on"}, {}}}, 1);
+ Declaration asof_join{
+ "asofjoin", {std::move(left), std::move(right)}, std::move(asof_join_opts)};
+
+ // Setting invalid arguments, such as nullptr in generator or schema in SinkNodeOptions,
+ // causes the execution plan to terminate before the asofjoin node is started.
+ arrow::acero::SinkNodeOptions sink_node_options{/*generator=*/nullptr,
+ /*schema=*/nullptr};
+ arrow::acero::Declaration sink =
+ arrow::acero::Declaration::Sequence({asof_join, {"sink", sink_node_options}});
Review Comment:
Can we simplify this?
```suggestion
auto sink = Declaration::Sequence({asof_join, {"sink", sink_node_options}});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2468526871
Merging now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++] Fix crash when thread in asof_join is not running [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2446613387
:warning: GitHub issue #44526 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2450398466
> @zanmato1984 Do you think this test is enough?
Thank you for the update. The test should suffice at my first glance. I'll take a deeper look soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2447448343
Hi @mroz45 , thanks for fixing this!
I think we still need a reproducible C++ UT. If you have any difficulties on that, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44526: [C++][Acero] Fix crash when thread in asof_join is not running [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44584:
URL: https://github.com/apache/arrow/pull/44584#issuecomment-2469287883
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cf10b4066e3c5a9c0bee103d351203a87beb61aa.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/32833878337) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org