[GitHub] [kvrocks] enjoy-binbin commented on a diff in pull request #1625: Fix GEOSEARCH/GEOSEARCHSTORE FROMMEMBER against non existing src key reply

["enjoy-binbin (via GitHub)" <gi...@apache.org>]

enjoy-binbin commented on code in PR #1625:
URL: https://github.com/apache/kvrocks/pull/1625#discussion_r1278969779


##########
tests/gocase/unit/geo/geo_test.go:
##########
@@ -139,6 +139,11 @@ func TestGeo(t *testing.T) {
 		require.EqualValues(t, []interface{}{nil, nil, nil}, rdb.Do(ctx, "GEOHASH", "points", "a", "b", "c").Val())
 	})
 
+	t.Run("GEOSEARCH against non existing src key", func(t *testing.T) {
+		require.NoError(t, rdb.Del(ctx, "points").Err())
+		require.EqualValues(t, []interface{}([]interface {}{}), rdb.Do(ctx, "GEOSEARCH", "src", "FROMMEMBER", "Shenzhen", "BYBOX", 88, 88, "m").Val())

Review Comment:
   ```suggestion
   		require.EqualValues(t, []interface{}([]interface{}{}), rdb.Do(ctx, "GEOSEARCH", "src", "FROMMEMBER", "Shenzhen", "BYBOX", 88, 88, "m").Val())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org