You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Milind Bhandarkar (JIRA)" <ji...@apache.org> on 2007/11/07 01:07:50 UTC

[jira] Created: (PIG-23) Make Pig work with Java 1.5

Make Pig work with Java 1.5
---------------------------

                 Key: PIG-23
                 URL: https://issues.apache.org/jira/browse/PIG-23
             Project: Pig
          Issue Type: Improvement
          Components: impl
    Affects Versions: 0.0.0
         Environment: All
            Reporter: Milind Bhandarkar
             Fix For: 0.1.0
         Attachments: pig.patch

With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


RE: [jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by Olga Natkovich <ol...@yahoo-inc.com>.
I think so 

-----Original Message-----
From: Alan Gates (JIRA) [mailto:jira@apache.org] 
Sent: Wednesday, November 07, 2007 5:52 PM
To: pig-dev@incubator.apache.org
Subject: [jira] Commented: (PIG-23) Make Pig work with Java 1.5


    [
https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plu
gin.system.issuetabpanels:comment-tabpanel#action_12540948 ] 

Alan Gates commented on PIG-23:
-------------------------------

We seem to have come to agreement that we need to support 1.5 in
addition to 1.6.  Can I move forward with committing this patch?

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>            Assignee: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need
it to work with JDK5, because my Mac does not have JDK 6.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by Utkarsh Srivastava <ut...@yahoo-inc.com>.
I think, it is worthwhile to make it work with 1.5 while 1.6 is still  
in beta for Mac.

Utkarsh

On Nov 7, 2007, at 8:05 AM, Olga Natkovich (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/PIG-23? 
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment- 
> tabpanel#action_12540777 ]
>
> Olga Natkovich commented on PIG-23:
> -----------------------------------
>
> Do we really need to make it work with 1.5? I think it might be  
> hard for us to make sure that it works going forward anyways.
>
>> Make Pig work with Java 1.5
>> ---------------------------
>>
>>                 Key: PIG-23
>>                 URL: https://issues.apache.org/jira/browse/PIG-23
>>             Project: Pig
>>          Issue Type: Improvement
>>          Components: impl
>>    Affects Versions: 0.0.0
>>         Environment: All
>>            Reporter: Milind Bhandarkar
>>             Fix For: 0.1.0
>>
>>         Attachments: pig.patch
>>
>>
>> With a few changes, I am able to make Pig build with Java 1.5. I  
>> need it to work with JDK5, because my Mac does not have JDK 6.
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540777 ] 

Olga Natkovich commented on PIG-23:
-----------------------------------

Do we really need to make it work with 1.5? I think it might be hard for us to make sure that it works going forward anyways.

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milind Bhandarkar updated PIG-23:
---------------------------------

    Patch Info: [Patch Available]

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milind Bhandarkar updated PIG-23:
---------------------------------

    Attachment:     (was: pig.patch)

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540948 ] 

Alan Gates commented on PIG-23:
-------------------------------

We seem to have come to agreement that we need to support 1.5 in addition to 1.6.  Can I move forward with committing this patch?

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>            Assignee: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540831 ] 

Doug Cutting commented on PIG-23:
---------------------------------

> e.toString() includes the stack-trace

No, not generally.  I think instead of setStackTrace() you should use initCause(Throwable).

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540771 ] 

Benjamin Reed commented on PIG-23:
----------------------------------

The problem with this patch is we lose track of the cause of the problem. Perhaps it would be better to do something like

newE = new IOException(e.getMessage());
newE.setStackTrace(e.getStackTrace);
throw newE;

that way when the error happens we can figure out what was going on.

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540847 ] 

Milind Bhandarkar commented on PIG-23:
--------------------------------------

Okay, I will upload another patch.

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milind Bhandarkar updated PIG-23:
---------------------------------

    Attachment: pig.patch

Updated patch.

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540834 ] 

Torsten Curdt commented on PIG-23:
----------------------------------

Totally agree. I don't see any good reason why Pig should require 1.6 at this stage. Don't make it harder for the users (and developers under OSX - that includes me) than it already is.

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milind Bhandarkar updated PIG-23:
---------------------------------

    Patch Info:   (was: [Patch Available])

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milind Bhandarkar reassigned PIG-23:
------------------------------------

    Assignee: Milind Bhandarkar

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>            Assignee: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540845 ] 

Benjamin Reed commented on PIG-23:
----------------------------------

Doug is correct. We should use initCause:

newE = new IOException(e.getMessage());
newE.initCause(e);
throw newE;

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540829 ] 

Milind Bhandarkar commented on PIG-23:
--------------------------------------

Olga, I see three issues:

1. Java 1.6 is the *latest* version. Sysadmins and deployments *usually* stay a version behind.
2. Hadoop, which Pig depends on, requires 1.5 only.
3. Mac OSX (even Leopard) does not have 1.6 yet (AFAIK).

Ben, e.toString() includes the stack-trace for e already, right ?

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Milind Bhandarkar updated PIG-23:
---------------------------------

    Attachment: pig.patch

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by Ted Dunning <td...@veoh.com>.

I develop on a mac and don't have access to 1.6 unless I am connected to
machines in my office.  Requiring 1.6 would be a real pain in the ass.

In addition, as of a month and a half ago, 1.6 was demonstrably less stable
for us than 1.5 in our production applications.  I could run 1.6 just for
hadoop, but I would really rather wait until 1.6 is really stable.  When I
say less stable, I mean that over a period of a week or so, servers with
heavy load would crash due to mysterious causes about 5 times with 1.6 and
virtually never with 1.5.  The differences were statistically significant
and persistent.


On 11/7/07 11:34 AM, "Owen O'Malley (JIRA)" <ji...@apache.org> wrote:

> 
>     [ 
> https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.sy
> stem.issuetabpanels:comment-tabpanel#action_12540855 ]
> 
> Owen O'Malley commented on PIG-23:
> ----------------------------------
> 
> Arguably, we should move Hadoop to require 1.6. In practice, the performance
> of the servers is much much better under 1.6...
> 
>> Make Pig work with Java 1.5
>> ---------------------------
>> 
>>                 Key: PIG-23
>>                 URL: https://issues.apache.org/jira/browse/PIG-23
>>             Project: Pig
>>          Issue Type: Improvement
>>          Components: impl
>>    Affects Versions: 0.0.0
>>         Environment: All
>>            Reporter: Milind Bhandarkar
>>             Fix For: 0.1.0
>> 
>> 
>> With a few changes, I am able to make Pig build with Java 1.5. I need it to
>> work with JDK5, because my Mac does not have JDK 6.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540855 ] 

Owen O'Malley commented on PIG-23:
----------------------------------

Arguably, we should move Hadoop to require 1.6. In practice, the performance of the servers is much much better under 1.6...

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-23) Make Pig work with Java 1.5

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540879 ] 

Milind Bhandarkar commented on PIG-23:
--------------------------------------

Owen, one can have source-level compatibility with 1.5, and use more performant jre 1.6, right ?

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-23) Make Pig work with Java 1.5

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates resolved PIG-23.
---------------------------

    Resolution: Fixed

Fixed checked in.  Thanks Milind.

> Make Pig work with Java 1.5
> ---------------------------
>
>                 Key: PIG-23
>                 URL: https://issues.apache.org/jira/browse/PIG-23
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.0.0
>         Environment: All
>            Reporter: Milind Bhandarkar
>            Assignee: Milind Bhandarkar
>             Fix For: 0.1.0
>
>         Attachments: pig.patch
>
>
> With a few changes, I am able to make Pig build with Java 1.5. I need it to work with JDK5, because my Mac does not have JDK 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.