You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Mortom123 (via GitHub)" <gi...@apache.org> on 2024/01/30 08:12:05 UTC
[PR] rename broker-rbac.yaml to function-worker-rbac.yaml [pulsar-helm-chart]
Mortom123 opened a new pull request, #452:
URL: https://github.com/apache/pulsar-helm-chart/pull/452
Fixes #426
### Motivation
Motivated by naming files accordingly to what they do.
### Modifications
Rename files.
### Verifying this change
- [X] Make sure that the change passes the CI checks. (Didn't check but probably will)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename broker-rbac.yaml to function-worker-rbac.yaml [pulsar-helm-chart]
Posted by "Mortom123 (via GitHub)" <gi...@apache.org>.
Mortom123 commented on PR #452:
URL: https://github.com/apache/pulsar-helm-chart/pull/452#issuecomment-1919280259
Running: https://github.com/Mortom123/pulsar-helm-chart/actions/runs/7727993730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename broker-rbac.yaml to function-worker-rbac.yaml [pulsar-helm-chart]
Posted by "Mortom123 (via GitHub)" <gi...@apache.org>.
Mortom123 commented on code in PR #452:
URL: https://github.com/apache/pulsar-helm-chart/pull/452#discussion_r1472948824
##########
charts/pulsar/templates/function-worker-rbac.yaml:
##########
@@ -17,6 +17,7 @@
# under the License.
#
+{{- if .Values.rbac.enabled }}
Review Comment:
Ok. I will remove it from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename broker-rbac.yaml to function-worker-rbac.yaml [pulsar-helm-chart]
Posted by "Mortom123 (via GitHub)" <gi...@apache.org>.
Mortom123 commented on code in PR #452:
URL: https://github.com/apache/pulsar-helm-chart/pull/452#discussion_r1472922739
##########
charts/pulsar/values.yaml:
##########
@@ -930,7 +930,7 @@ functions:
component: functions-worker
useBookieAsStateStore: false
## Pulsar: Functions Worker ClusterRole or Role
- ## templates/broker-rbac.yaml
+ ## templates/function-worker-rbac.yaml
Review Comment:
i guess that would be the best solution. will do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename broker-rbac.yaml to function-worker-rbac.yaml [pulsar-helm-chart]
Posted by "Mortom123 (via GitHub)" <gi...@apache.org>.
Mortom123 closed pull request #452: rename broker-rbac.yaml to function-worker-rbac.yaml
URL: https://github.com/apache/pulsar-helm-chart/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] rename broker-rbac.yaml to function-worker-rbac.yaml [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #452:
URL: https://github.com/apache/pulsar-helm-chart/pull/452#discussion_r1472750915
##########
charts/pulsar/templates/function-worker-rbac.yaml:
##########
@@ -17,6 +17,7 @@
# under the License.
#
+{{- if .Values.rbac.enabled }}
Review Comment:
Adding this condition will break Pulsar Functions support. It is mandatory when `.Values.components.functions` is enabled. That's why adding this condition is problematic. Perhaps we instead need to clarify the documentation of `rbac.enabled` and explain that RBAC will be always configured for Pulsar Functions regardless of `rbac.enabled`.
##########
charts/pulsar/values.yaml:
##########
@@ -930,7 +930,7 @@ functions:
component: functions-worker
useBookieAsStateStore: false
## Pulsar: Functions Worker ClusterRole or Role
- ## templates/broker-rbac.yaml
+ ## templates/function-worker-rbac.yaml
Review Comment:
In the current Pulsar Helm Chart, there isn't a separate `function-worker` pod. The `function-worker` role is handled by the broker. Perhaps we should rename the file to be `broker-function-worker-rbac.yaml` to indicate this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org