You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/23 00:27:41 UTC
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15786
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
[test] fix TestCorruptKerberosCC scenario
On macOS, the SecurityITest.TestCorruptKerberosCC scenario was failing
with errors like below:
src/kudu/integration-tests/security-itest.cc:430: Failure
Value of: s.ok()
Actual: true
Expected: false
Google Test trace:
src/kudu/integration-tests/security-itest.cc:419: Truncating ccache at
'security-itest.0.SecurityITest.TestCorruptKerberosCC/krb5kdc/krb5cc' to 500
It seems Kerberos cache truncated to 500 bytes is big enough to
successfully extract necessary data on macOS.
This patch decreases the size of the corrupted client cache to 256 bytes,
so now the scenario passes on macOS as well.
Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/15786/1
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15786 )
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Apr 2020 01:57:23 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15786 )
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Apr 2020 17:41:34 +0000
Gerrit-HasComments: No
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15786 )
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15786/1/src/kudu/integration-tests/security-itest.cc
File src/kudu/integration-tests/security-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15786/1/src/kudu/integration-tests/security-itest.cc@415
PS1, Line 415: {10, 75, 256}
> Curious what's the significance of these particular values? Could it be rep
I guess these might be randomly selected. The important thing is the upper limit, yup.
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Apr 2020 01:44:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Hao Hao, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15786
to look at the new patch set (#2).
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
[test] fix TestCorruptKerberosCC scenario
On macOS, the SecurityITest.TestCorruptKerberosCC scenario was failing
with errors like below:
src/kudu/integration-tests/security-itest.cc:430: Failure
Value of: s.ok()
Actual: true
Expected: false
Google Test trace:
src/kudu/integration-tests/security-itest.cc:419: Truncating ccache at
'security-itest.0.SecurityITest.TestCorruptKerberosCC/krb5kdc/krb5cc' to 500
It seems Kerberos cache truncated to 500 bytes is big enough to
successfully extract necessary data on macOS.
This patch decreases the size of the corrupted client cache to 266
bytes, so now the scenario passes on macOS as well. In addition,
the truncation size is now selected randomly.
Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/15786/2
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15786 )
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
[test] fix TestCorruptKerberosCC scenario
On macOS, the SecurityITest.TestCorruptKerberosCC scenario was failing
with errors like below:
src/kudu/integration-tests/security-itest.cc:430: Failure
Value of: s.ok()
Actual: true
Expected: false
Google Test trace:
src/kudu/integration-tests/security-itest.cc:419: Truncating ccache at
'security-itest.0.SecurityITest.TestCorruptKerberosCC/krb5kdc/krb5cc' to 500
It seems Kerberos cache truncated to 500 bytes is big enough to
successfully extract necessary data on macOS.
This patch decreases the size of the corrupted client cache to 266
bytes, so now the scenario passes on macOS as well. In addition,
the truncation size is now selected randomly.
Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Reviewed-on: http://gerrit.cloudera.org:8080/15786
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Bankim Bhavsar: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] fix TestCorruptKerberosCC scenario
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15786 )
Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15786/1/src/kudu/integration-tests/security-itest.cc
File src/kudu/integration-tests/security-itest.cc:
http://gerrit.cloudera.org:8080/#/c/15786/1/src/kudu/integration-tests/security-itest.cc@415
PS1, Line 415: {10, 75, 256}
Curious what's the significance of these particular values? Could it be replaced with random values with some upper limit?
--
To view, visit http://gerrit.cloudera.org:8080/15786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15786
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Apr 2020 00:38:34 +0000
Gerrit-HasComments: Yes