[GitHub] [struts] sepe81 commented on a diff in pull request #552: [WW-5165] Upgrades Spring to version 5.3.20

[GitBox <gi...@apache.org>]

sepe81 commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874808304


##########
core/pom.xml:
##########
@@ -242,6 +242,16 @@
             <artifactId>spring-web</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-context</artifactId>

Review Comment:
   background: Add spring-context for testing with StaticApplicationContext



##########
plugins/portlet-mocks/pom.xml:
##########
@@ -51,6 +51,7 @@
     </dependencies>
 
     <properties>
+        <spring.platformVersion>4.3.30.RELEASE</spring.platformVersion>

Review Comment:
   good idea, to freeze the spring version here



##########
plugins/portlet/pom.xml:
##########
@@ -130,11 +130,7 @@
             <artifactId>spring-test</artifactId>
             <optional>true</optional>
         </dependency>
-        <dependency>

Review Comment:
   Maybe we could add some additional infos to the commit to clarify the context
   
   Remove unused spring-webmvc-portlet
   Spring 5.x dropped support for spring-webmvc-portlet
   https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-5.x#dropped-support



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org