You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Ugo Matrangolo (JIRA)" <ji...@apache.org> on 2007/05/29 23:47:15 UTC
[jira] Created: (DERBY-2726) convert lang/AIjdbc.java to JUnit
convert lang/AIjdbc.java to JUnit
---------------------------------
Key: DERBY-2726
URL: https://issues.apache.org/jira/browse/DERBY-2726
Project: Derby
Issue Type: Test
Components: Test
Reporter: Ugo Matrangolo
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2726:
----------------------------------
Attachment: DERBY-2726_stat_290507.txt
DERBY-2726_diff_290507.txt
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499946 ]
Ugo Matrangolo commented on DERBY-2726:
---------------------------------------
Initial draft of the conversion of this test.
I'm unsure on how I handled the fact that the test is tagged as EMBEDDED on the wiki page; please, confirm my code.
Please review,
Ugo.
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2726:
----------------------------------
Attachment: DERBY-2726_stat_090607.txt
DERBY-2726_diff_090607.txt
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_090607.txt, DERBY-2726_diff_290507.txt, DERBY-2726_stat_090607.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503159 ]
Ugo Matrangolo commented on DERBY-2726:
---------------------------------------
Thanks Kathey for your comments.
I modified the code accordingly (I hope :)).
Please check if the package where I placed the new test is correct and if the test configuration is correct. The rest of the code is untouched.
Please review,
-- Ugo.
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_090607.txt, DERBY-2726_diff_290507.txt, DERBY-2726_stat_090607.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2726:
----------------------------------
Derby Info: (was: [Patch Available])
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_090607.txt, DERBY-2726_diff_290507.txt, DERBY-2726_stat_090607.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-2726:
----------------------------------
Derby Info: (was: [Patch Available])
Uncheck patch available since there are review comments that need to be incorporated.
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by Mayuresh Nirhali <Ma...@Sun.COM>.
Please look at, Derby-1355.
As part of the test fix, I have modified LangHarnessTest to run AIjdbc
test in CLIENT mode as well. The patches are ready for review.
There is a test fix proposed through DERBY-1355 and JUnit conversion
proposed through this bug.
I think, these 2 activities can be handled in following different ways,
1. Wait for 1355 to be committed and then produce a new patch based on
that change for this bug.
2. 1355 test fix is separated in a different patch. After review, do not
commit the test patch. Instead, make necessary changes (Test running in
CLIENT mode as well) in the patch for 2726.
3. Create a patch for this bug without making the test runnable in
CLIENT mode, wait for commit. Update the converted test to be run in
CLIENT mode with a new patch for DERBY-1355.
Please let me know what will be the most preferred way.
I will make changes accordingly to 1355.
Regards
Mayuresh
Kathey Marsden (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499957 ]
>
> Kathey Marsden commented on DERBY-2726:
> ---------------------------------------
>
> Thanks Ugo for converting the test.
> The mention of EMBEDDED on the Wiki page means that the old test is running in LangHarnessJavaTest only in embedded mode. It should be removed from org.apache.derbyTesting.functionTests.tests.lang.LangHarnessJavaTest now that you are adding the new test. Also the old file AIjdbc.java should be removed.
>
> I think it would be good to run this test in client mode as well to get coverage for the client driver for these ResultSetMetaData methods. I also think it would be good to move the test to the jdbc suite from lang.
> I think it was in the wrong suite to start with. It would be nice to have some javadoc, but otherwise your test looks good to me.
>
>
>
>
>
>> convert lang/AIjdbc.java to JUnit
>> ---------------------------------
>>
>> Key: DERBY-2726
>> URL: https://issues.apache.org/jira/browse/DERBY-2726
>> Project: Derby
>> Issue Type: Test
>> Components: Test
>> Reporter: Ugo Matrangolo
>> Assignee: Ugo Matrangolo
>> Priority: Minor
>> Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>>
>>
>>
>
>
>
[jira] Commented: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499957 ]
Kathey Marsden commented on DERBY-2726:
---------------------------------------
Thanks Ugo for converting the test.
The mention of EMBEDDED on the Wiki page means that the old test is running in LangHarnessJavaTest only in embedded mode. It should be removed from org.apache.derbyTesting.functionTests.tests.lang.LangHarnessJavaTest now that you are adding the new test. Also the old file AIjdbc.java should be removed.
I think it would be good to run this test in client mode as well to get coverage for the client driver for these ResultSetMetaData methods. I also think it would be good to move the test to the jdbc suite from lang.
I think it was in the wrong suite to start with. It would be nice to have some javadoc, but otherwise your test looks good to me.
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2726:
----------------------------------
Derby Info: [Patch Available]
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_090607.txt, DERBY-2726_diff_290507.txt, DERBY-2726_stat_090607.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo closed DERBY-2726.
---------------------------------
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2726_diff_090607.txt, DERBY-2726_diff_290507.txt, DERBY-2726_stat_090607.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden resolved DERBY-2726.
-----------------------------------
Resolution: Fixed
Fix Version/s: 10.3.0.0
committed to trunk with revision 546644.
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2726_diff_090607.txt, DERBY-2726_diff_290507.txt, DERBY-2726_stat_090607.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo updated DERBY-2726:
----------------------------------
Derby Info: [Patch Available]
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2726_diff_290507.txt, DERBY-2726_stat_290507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2726) convert lang/AIjdbc.java to JUnit
Posted by "Ugo Matrangolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ugo Matrangolo reassigned DERBY-2726:
-------------------------------------
Assignee: Ugo Matrangolo
> convert lang/AIjdbc.java to JUnit
> ---------------------------------
>
> Key: DERBY-2726
> URL: https://issues.apache.org/jira/browse/DERBY-2726
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assignee: Ugo Matrangolo
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.