You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/08 09:10:19 UTC
[GitHub] [apisix] spacewander opened a new issue, #7886: help request: should we move the reload api from Admin API to Control API
spacewander opened a new issue, #7886:
URL: https://github.com/apache/apisix/issues/7886
### Description
Currently, we have an API that reloads the plugin in the Admin API: https://apisix.apache.org/docs/apisix/terminology/plugin/#hot-reload. After years of usage, we find this design has some issues:
1. its logic is complex
2. it requires every node has the same plugin and static configuration.
3. its usage is limited
As the reload API is mainly used for dev or debug purposes, moving this API into the control API would be more appreciated. What about your ideas?
### Environment
- APISIX version (run `apisix version`): 2.15.0
- Operating system (run `uname -a`):
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
- etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #7886:
URL: https://github.com/apache/apisix/issues/7886#issuecomment-1240448771
Agree +1 from me.
It's my understanding that plugin reload is a "foreign" operation in Admin API. It doesn't like other operations which focus on specific objects. The plugin reload is an ops operation and should only be executed by the ops developer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by GitBox <gi...@apache.org>.
hf400159 commented on issue #7886:
URL: https://github.com/apache/apisix/issues/7886#issuecomment-1245193276
agree +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #7886:
URL: https://github.com/apache/apisix/issues/7886#issuecomment-1244881021
agree +1 for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #7886:
URL: https://github.com/apache/apisix/issues/7886#issuecomment-1240502478
Agree +1.
In Admin API, it will be conflicted if there is a plugin called `reload.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7886:
URL: https://github.com/apache/apisix/issues/7886#issuecomment-1729259329
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7886:
URL: https://github.com/apache/apisix/issues/7886#issuecomment-1709874389
This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] closed issue #7886: help request: should we move the reload api from Admin API to Control API
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7886: help request: should we move the reload api from Admin API to Control API
URL: https://github.com/apache/apisix/issues/7886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org