You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Vishal K (JIRA)" <ji...@apache.org> on 2011/01/05 07:48:45 UTC
[jira] Created: (ZOOKEEPER-973) bind() could fail on Leader because
it does not setReuseAddress on its ServerSocket
bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
------------------------------------------------------------------------------------
Key: ZOOKEEPER-973
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.3.2
Reporter: Vishal K
Priority: Trivial
Fix For: 3.3.3
setReuseAddress(true) should be used below.
Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
this.self = self;
try {
ss = new ServerSocket(self.getQuorumAddress().getPort());
} catch (BindException e) {
LOG.error("Couldn't bind to port "
+ self.getQuorumAddress().getPort(), e);
throw e;
}
this.zk=zk;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192067#comment-13192067 ]
Hudson commented on ZOOKEEPER-973:
----------------------------------
Integrated in ZooKeeper-trunk #1438 (See [https://builds.apache.org/job/ZooKeeper-trunk/1438/])
ZOOKEEPER-973. bind() could fail on Leader because it does not setReuseAddress on its ServerSocket (Harsh J via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234974
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.3.5, 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-973.patch, ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-973:
------------------------------------
Fix Version/s: (was: 3.4.0)
3.5.0
not a blocker. Moving it out of 3.4 release.
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal K
> Priority: Trivial
> Fix For: 3.5.0
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated ZOOKEEPER-973:
------------------------------
Attachment: ZOOKEEPER-973.patch
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Benjamin Reed (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189491#comment-13189491 ]
Benjamin Reed commented on ZOOKEEPER-973:
-----------------------------------------
+1 looks good
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch, ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180398#comment-13180398 ]
Hadoop QA commented on ZOOKEEPER-973:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509538/ZOOKEEPER-973.patch
against trunk revision 1227000.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/878//console
This message is automatically generated.
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-973) bind() could fail on Leader because
it does not setReuseAddress on its ServerSocket
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-973:
------------------------------------
Fix Version/s: (was: 3.3.3)
3.4.0
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal K
> Priority: Trivial
> Fix For: 3.4.0
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181126#comment-13181126 ]
Hadoop QA commented on ZOOKEEPER-973:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12509657/ZOOKEEPER-973.patch
against trunk revision 1227927.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/883//console
This message is automatically generated.
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch, ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188917#comment-13188917 ]
Harsh J commented on ZOOKEEPER-973:
-----------------------------------
Hey devs, are there any further comments you'd like me to address on this patch? Do let me know.
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch, ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated ZOOKEEPER-973:
------------------------------
Attachment: ZOOKEEPER-973.patch
Ah yes, sorry about that.
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch, ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-973) bind() could fail on Leader
because it does not setReuseAddress on its ServerSocket
Posted by "Harsh J (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned ZOOKEEPER-973:
---------------------------------
Assignee: Harsh J
> bind() could fail on Leader because it does not setReuseAddress on its ServerSocket
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-973
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-973
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2
> Reporter: Vishal Kher
> Assignee: Harsh J
> Priority: Trivial
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-973.patch
>
>
> setReuseAddress(true) should be used below.
> Leader(QuorumPeer self,LeaderZooKeeperServer zk) throws IOException {
> this.self = self;
> try {
> ss = new ServerSocket(self.getQuorumAddress().getPort());
> } catch (BindException e) {
> LOG.error("Couldn't bind to port "
> + self.getQuorumAddress().getPort(), e);
> throw e;
> }
> this.zk=zk;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira