You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2018/01/11 13:17:20 UTC
spark git commit: [SPARK-22967][TESTS] Fix VersionSuite's unit tests
by change Windows path into URI path
Repository: spark
Updated Branches:
refs/heads/master 1c70da3bf -> 0552c36e0
[SPARK-22967][TESTS] Fix VersionSuite's unit tests by change Windows path into URI path
## What changes were proposed in this pull request?
Two unit test will fail due to Windows format path:
1.test(s"$version: read avro file containing decimal")
```
org.apache.hadoop.hive.ql.metadata.HiveException: MetaException(message:java.lang.IllegalArgumentException: Can not create a Path from an empty string);
```
2.test(s"$version: SPARK-17920: Insert into/overwrite avro table")
```
Unable to infer the schema. The schema specification is required to create the table `default`.`tab2`.;
org.apache.spark.sql.AnalysisException: Unable to infer the schema. The schema specification is required to create the table `default`.`tab2`.;
```
This pr fix these two unit test by change Windows path into URI path.
## How was this patch tested?
Existed.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: wuyi5 <ng...@163.com>
Closes #20199 from Ngone51/SPARK-22967.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0552c36e
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0552c36e
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0552c36e
Branch: refs/heads/master
Commit: 0552c36e02434c60dad82024334d291f6008b822
Parents: 1c70da3
Author: wuyi5 <ng...@163.com>
Authored: Thu Jan 11 22:17:15 2018 +0900
Committer: hyukjinkwon <gu...@gmail.com>
Committed: Thu Jan 11 22:17:15 2018 +0900
----------------------------------------------------------------------
.../org/apache/spark/sql/hive/client/VersionsSuite.scala | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/0552c36e/sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
index ff90e9d..e64389e 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
@@ -811,7 +811,7 @@ class VersionsSuite extends SparkFunSuite with Logging {
test(s"$version: read avro file containing decimal") {
val url = Thread.currentThread().getContextClassLoader.getResource("avroDecimal")
- val location = new File(url.getFile)
+ val location = new File(url.getFile).toURI.toString
val tableName = "tab1"
val avroSchema =
@@ -851,6 +851,8 @@ class VersionsSuite extends SparkFunSuite with Logging {
}
test(s"$version: SPARK-17920: Insert into/overwrite avro table") {
+ // skipped because it's failed in the condition on Windows
+ assume(!(Utils.isWindows && version == "0.12"))
withTempDir { dir =>
val avroSchema =
"""
@@ -875,10 +877,10 @@ class VersionsSuite extends SparkFunSuite with Logging {
val writer = new PrintWriter(schemaFile)
writer.write(avroSchema)
writer.close()
- val schemaPath = schemaFile.getCanonicalPath
+ val schemaPath = schemaFile.toURI.toString
val url = Thread.currentThread().getContextClassLoader.getResource("avroDecimal")
- val srcLocation = new File(url.getFile).getCanonicalPath
+ val srcLocation = new File(url.getFile).toURI.toString
val destTableName = "tab1"
val srcTableName = "tab2"
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org