You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/08 15:42:19 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28226: Removed unused presto integration tests
potiuk opened a new pull request, #28226:
URL: https://github.com/apache/airflow/pull/28226
After the Presto -> Trino fork, Presto seem to be on its way out. They stopped being community friendly, and even Amazon dropped the suport for Presto in favour of Trino, also Facebook does not seem to be a great shehphard for Presto - for 1.5 years after the split they were not even able to release a good, supported and upgraded Docker image that could be attributed to the project and not some random 2GB images published by random people.
We cannot run those integration tests without a proper Presto container, and we've waited long enough - after the recent integration tests separation it became clear that it makes little sense to keep those stale and unused tests in our repo.
We can always bring them back when the situation improves on the Presto side and they will become more community-friendly.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28226: Removed unused presto integration tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28226:
URL: https://github.com/apache/airflow/pull/28226#issuecomment-1343184346
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28226: Removed unused presto integration tests
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28226:
URL: https://github.com/apache/airflow/pull/28226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28226: Removed unused presto integration tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28226:
URL: https://github.com/apache/airflow/pull/28226#issuecomment-1343078678
> This also some kind of integration test for presto which we not run, I thought we also could remove it:
Good point :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28226: Removed unused presto integration tests
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28226:
URL: https://github.com/apache/airflow/pull/28226#issuecomment-1342944634
This also some kind of integration test for presto which we not run, I thought we also could remove it:
https://github.com/apache/airflow/blob/e948b55a087f98d25a6a4730bf58f61689cdb116/tests/providers/mysql/transfers/test_presto_to_mysql.py#L65-L80
https://github.com/apache/airflow/blob/e948b55a087f98d25a6a4730bf58f61689cdb116/tests/providers/common/sql/sensors/test_sql.py#L245-L255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org