You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/20 18:59:50 UTC

[GitHub] [incubator-druid] gianm commented on a change in pull request #8870: Additional Kinesis resharding fixes

gianm commented on a change in pull request #8870: Additional Kinesis resharding fixes
URL: https://github.com/apache/incubator-druid/pull/8870#discussion_r348278414
 
 

 ##########
 File path: extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java
 ##########
 @@ -229,39 +228,34 @@ protected void scheduleReporting(ScheduledExecutorService reportingExec)
   @Override
   protected int getTaskGroupIdForPartition(String partitionId)
   {
-    if (!partitionIds.contains(partitionId)) {
 
 Review comment:
   The Kafka supervisor has a similar block. If it's pointless now, please remove that too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org