You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/07/18 09:32:04 UTC
[GitHub] [drill] vvysotskyi opened a new pull request, #2602: DRILL-7523: Update Calcite to 1.31.0
vvysotskyi opened a new pull request, #2602:
URL: https://github.com/apache/drill/pull/2602
# [DRILL-7523](https://issues.apache.org/jira/browse/DRILL-7523): Update Calcite to 1.31.0
## Description
Changes required for updating Calcite to 1.31.0. For now, the master version built by JitPack is used. After Calcite 1.31.0 is released, this PR will be updated to use that version.
No Drill-specific commits in Calcite are required after this change, so the https://github.com/vvysotskyi/drill-calcite repository will be archived after merging this PR.
## Documentation
NA
## Testing
All unit tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2602: DRILL-7523: Update Calcite to 1.31.0
Posted by GitBox <gi...@apache.org>.
cgivre commented on PR #2602:
URL: https://github.com/apache/drill/pull/2602#issuecomment-1188471668
@vvysotskyi This is really amazing work! Are you keeping this in draft until Calcite releases version 1.31, or is there additional work you are working on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2602: DRILL-7523: Update Calcite to 1.31.0
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on PR #2602:
URL: https://github.com/apache/drill/pull/2602#issuecomment-1188677015
@cgivre, yes, I'm keeping it in draft until the Calcite 1.31 release, no additional work is required for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2602: DRILL-7523: Update Calcite to 1.31.0
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on PR #2602:
URL: https://github.com/apache/drill/pull/2602#issuecomment-1203168678
Now it has the latest official released Calcite (and Avativa) version, so it is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a diff in pull request #2602: DRILL-7523: Update Calcite to 1.31.0
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on code in PR #2602:
URL: https://github.com/apache/drill/pull/2602#discussion_r936273407
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlSelectBuilder.java:
##########
@@ -90,8 +91,14 @@ public SqlSelectBuilder fetch(SqlNode fetch) {
return this;
}
+ public SqlSelectBuilder hints(SqlNodeList hints) {
Review Comment:
In the future, I think we will use this functionality to provide more flexibility for configuring the planning process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on a diff in pull request #2602: DRILL-7523: Update Calcite to 1.31.0
Posted by GitBox <gi...@apache.org>.
cgivre commented on code in PR #2602:
URL: https://github.com/apache/drill/pull/2602#discussion_r936171984
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlSelectBuilder.java:
##########
@@ -90,8 +91,14 @@ public SqlSelectBuilder fetch(SqlNode fetch) {
return this;
}
+ public SqlSelectBuilder hints(SqlNodeList hints) {
Review Comment:
@vvysotskyi Will Drill do anything with the SQL hints that Calcite now supports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi merged pull request #2602: DRILL-7523: Update Calcite to 1.31.0
Posted by GitBox <gi...@apache.org>.
vvysotskyi merged PR #2602:
URL: https://github.com/apache/drill/pull/2602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org