You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2024/07/16 13:55:01 UTC
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21589
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
IMPALA-13227: test_spilling_hash_join should be marked for serial execution
test_spilling_hash_join consumes too much resources and parallel
tests can fail because of it. We should mark it for serial execution.
Testing:
* had a green exhaustive run, and we also now that before
test_spilling_hash_join was added, the exhaustive runs
were much stable
Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
---
M tests/query_test/test_join_queries.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/21589/1
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 18:31:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16520/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 14:20:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 18:30:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10796/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 18:31:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 15:05:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
IMPALA-13227: test_spilling_hash_join should be marked for serial execution
test_spilling_hash_join consumes too much resources and parallel
tests can fail because of it. We should mark it for serial execution.
Testing:
* had a green exhaustive run, and we also now that before
test_spilling_hash_join was added, the exhaustive runs
were much stable
Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Reviewed-on: http://gerrit.cloudera.org:8080/21589
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_join_queries.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13227: test spilling hash join should be marked for serial execution
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21589 )
Change subject: IMPALA-13227: test_spilling_hash_join should be marked for serial execution
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b50376db9dde5b33a02fde55880f49a7db4b7c1
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 23:41:56 +0000
Gerrit-HasComments: No