You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/06/27 08:54:06 UTC
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4999: codecov module should contain the spark 3.4 profile
pan3793 commented on code in PR #4999:
URL: https://github.com/apache/kyuubi/pull/4999#discussion_r1243379727
##########
dev/kyuubi-codecov/pom.xml:
##########
@@ -209,5 +209,16 @@
</dependency>
</dependencies>
</profile>
+ <profile>
+ <id>spark-3.4</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-spark-connector-kudu_${scala.binary.version}</artifactId>
Review Comment:
actually, I'm going to remove this dummy module ...
##########
dev/kyuubi-codecov/pom.xml:
##########
@@ -209,5 +209,16 @@
</dependency>
</dependencies>
</profile>
+ <profile>
+ <id>spark-3.4</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-spark-connector-kudu_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <!-- TODO Support Apache Spark 3.4 for KSHC -->
Review Comment:
let's fix and add this one instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org