You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/16 02:47:49 UTC

[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #11492: [Feature][Style] Configure Spotless to format SQL code in DS

EricGao888 opened a new issue, #11492:
URL: https://github.com/apache/dolphinscheduler/issues/11492

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   * We have quite some sql scripts under `dolphinscheduler-dao/src/main/resources` for db initialization / upgrade. We could configure `Spotless` to format these scripts.
   
   ### Use case
   
   * Already described above.
   
   ### Related issues
   
   related: #10963
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on issue #11492: [Feature][Style] Configure Spotless to format SQL code in DS

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #11492:
URL: https://github.com/apache/dolphinscheduler/issues/11492#issuecomment-1290060822

   I'm closing it at this moment because the format of SQL provided by `spotless` using `dbeaver` style seems not favored by some developers. Will reopen it when `spotless` supports a prettier SQL formating.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 closed issue #11492: [Feature][Style] Configure Spotless to format SQL code in DS

Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #11492: [Feature][Style] Configure Spotless to format SQL code in DS
URL: https://github.com/apache/dolphinscheduler/issues/11492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11492: [Feature][Style] Configure Spotless to format SQL code in DS

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11492:
URL: https://github.com/apache/dolphinscheduler/issues/11492#issuecomment-1216082420

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org