You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/09/25 15:00:16 UTC
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24948
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
IMPALA-15422: Fix fall-through in system table DECIMAL writer
The switch in WriteDecimalSlot() (system-table-scanner.cc) had no
break statements, so after writing the value with the correct width
it also wrote it as a Decimal16Value to the same address. All DECIMAL
columns of sys.impala_query_live are DECIMAL(18,3), i.e. 8 bytes
wide, so every write also overwrote the next 8 bytes of the tuple.
Depending on the selected columns, this zeroed other slots or null
indicators. E.g. 'select backends_count, total_time_ms from
sys.impala_query_live' returned 0 for backends_count.
This patch adds the missing break statements.
Testing:
- Added a custom cluster test that selects backends_count together
with each DECIMAL column of sys.impala_query_live. It failed
without the fix.
Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Assisted-by: Claude Opus 5.5 (1M context) <no...@anthropic.com>
---
M be/src/exec/system-table-scanner.cc
M tests/custom_cluster/test_query_live.py
2 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/24948/1
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24187/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Sep 2026 15:23:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Nandor Kollar (Code Review)" <ge...@cloudera.org>.
Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 10:38:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 05:38:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14164/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 17:31:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 09:54:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
IMPALA-15422: Fix fall-through in system table DECIMAL writer
The switch in WriteDecimalSlot() (system-table-scanner.cc) had no
break statements, so after writing the value with the correct width
it also wrote it as a Decimal16Value to the same address. All DECIMAL
columns of sys.impala_query_live are DECIMAL(18,3), i.e. 8 bytes
wide, so every write also overwrote the next 8 bytes of the tuple.
Depending on the selected columns, this zeroed other slots or null
indicators. E.g. 'select backends_count, total_time_ms from
sys.impala_query_live' returned 0 for backends_count.
This patch adds the missing break statements.
Testing:
- Added a custom cluster test that selects backends_count together
with each DECIMAL column of sys.impala_query_live. It failed
without the fix.
Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Assisted-by: Claude Opus 5.5 (1M context) <no...@anthropic.com>
Reviewed-on: http://gerrit.cloudera.org:8080/24948
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/system-table-scanner.cc
M tests/custom_cluster/test_query_live.py
2 files changed, 29 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14164/
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 22:02:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14166/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 05:38:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 10:41:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14161/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 10:41:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15422: Fix fall-through in system table DECIMAL writer
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24948 )
Change subject: IMPALA-15422: Fix fall-through in system table DECIMAL writer
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I395a217c443f52d3588e0d25bdb1859fb245d04c
Gerrit-Change-Number: 24948
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 10:03:45 +0000
Gerrit-HasComments: No