You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/11 07:14:36 UTC

[GitHub] [dolphinscheduler] seedscoder opened a new issue, #11895: [Improvement][dolphinscheduler-api] When deleting a workflow definition, the task definition information should be deleted?

seedscoder opened a new issue, #11895:
URL: https://github.com/apache/dolphinscheduler/issues/11895

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   - When deleting a workflow definition (t_ds_process_definition), whether the task definition information should be deleted (physical deletion or logical deletion) (t_ds_task_definition)
   
   
   ```java
           int delete = processDefinitionMapper.deleteById(processDefinition.getId());
           if (delete == 0) {
               putMsg(result, Status.DELETE_PROCESS_DEFINE_BY_CODE_ERROR);
               throw new ServiceException(Status.DELETE_PROCESS_DEFINE_BY_CODE_ERROR);
           }
           int deleteRelation = processTaskRelationMapper.deleteByCode(project.getCode(), processDefinition.getCode());
           if (deleteRelation == 0) {
               logger.warn("The process definition has not relation, it will be delete successfully");
           }
           deleteOtherRelation(project, result, processDefinition);
   ```
   
   #
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11895: [Improvement][dolphinscheduler-api] When deleting a workflow definition, the task definition information should be deleted?

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11895:
URL: https://github.com/apache/dolphinscheduler/issues/11895#issuecomment-1242903867

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] stalary commented on issue #11895: [Improvement][dolphinscheduler-api] When deleting a workflow definition, the task definition information should be deleted?

Posted by GitBox <gi...@apache.org>.
stalary commented on issue #11895:
URL: https://github.com/apache/dolphinscheduler/issues/11895#issuecomment-1244802843

   https://github.com/apache/dolphinscheduler/pull/11490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] seedscoder closed issue #11895: [Improvement][dolphinscheduler-api] When deleting a workflow definition, the task definition information should be deleted?

Posted by GitBox <gi...@apache.org>.
seedscoder closed issue #11895: [Improvement][dolphinscheduler-api] When deleting a workflow definition, the task definition information should be deleted?
URL: https://github.com/apache/dolphinscheduler/issues/11895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org