You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/05/10 13:56:33 UTC
[GitHub] [flink] XComp commented on pull request #22561: [BP-1.17][FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException.
XComp commented on PR #22561:
URL: https://github.com/apache/flink/pull/22561#issuecomment-1542262592
Initially, I thought of backporting the junit5 migraiton as well. But it looks like we didn't do it in the past, either: `assertThatFuture` isn't backported. I backed off then because it felt like a quite big change to the `FutureUtilsTest` class just to have this kind-of cosmetic change (talking about the junit5 migration) be included as well. I didn't want to open the rabbit hole of migrating other JUnit5 migrations as well. WDYT? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org