[GitHub] [hive] deniskuzZ commented on a diff in pull request #3802: HIVE-26771: Use DDLTask to created Iceberg table when running ctas statement

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035623871


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -236,11 +236,25 @@ public void commitCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTabl
       setFileFormat(catalogProperties.getProperty(TableProperties.DEFAULT_FILE_FORMAT));
 
       String metadataLocation = hmsTable.getParameters().get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP);
+      Table table;

Review Comment:
   minor: i would use ternary operator here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org