You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benjamin Bentmann (JIRA)" <ji...@apache.org> on 2008/05/30 12:57:45 UTC
[jira] Created: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Support directory scanning based on Ant-like include/exclude patterns
---------------------------------------------------------------------
Key: IO-172
URL: https://issues.apache.org/jira/browse/IO-172
Project: Commons IO
Issue Type: New Feature
Components: Utilities
Affects Versions: 1.4
Reporter: Benjamin Bentmann
While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
{code:java}
Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
{code}
in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601243#action_12601243 ]
Matt Benson commented on IO-172:
--------------------------------
Any problem with including this implementation in [io], though?
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601233#action_12601233 ]
Niall Pemberton commented on IO-172:
------------------------------------
Right, or we would have pointed you to somemethod to use and just closed this as INVALID.
The real point though is that it seems to me that we already have some of the building blocks here in IO for such a thing and better IMO to start with that than copying in an Ant class. DirectoryWalker recursively scans directories, applying file filters - so I think if there was a file filter implementation that could do the pattern matching on paths and file names then it would be straight forward to provide the one line scanDirectory() method you're looking for.
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Posted by "Benjamin Bentmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601199#action_12601199 ]
Benjamin Bentmann commented on IO-172:
--------------------------------------
Hm, not really convenient, isn't it?
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Posted by "James Ring (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861492#action_12861492 ]
James Ring commented on IO-172:
-------------------------------
This is just like http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Predicate.html and http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Predicates.html, except it's ugly and my hands hurt just looking at the example code above.
Nicer would be something like:
import static org.apache.commons.io.filefilter.IOFileFilters.*;
scanDirectory(and(suffix(".xml"), not(name("bad"))));
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
> Fix For: 2.x
>
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601190#action_12601190 ]
Niall Pemberton commented on IO-172:
------------------------------------
> how would one search for files that match "*/.xml" but that don't match "bad/**"?
Currently, the way would be to create a DirectoryWalker implementation:
{code:java}
public class FileFinder extends DirectoryWalker {
public FileFinder(IOFileFilter dirFilter, IOFileFilter fileFilter, int depthLimit) {
super(dirFilter, fileFilter, depthLimit);
}
protected List find(File startDirectory) {
List results = new ArrayList();
try {
walk(startDirectory, results);
} catch(IOException ex) {
Assert.fail(ex.toString());
}
return results;
}
/** Handles a directory end by adding the File to the result set. */
protected void handleDirectoryEnd(File directory, int depth, Collection results) {
results.add(directory);
}
/** Handles a file by adding the File to the result set. */
protected void handleFile(File file, int depth, Collection results) {
results.add(file);
}
}
{code}
Then you use the file filter implementations to achieve what you want:
{code:java}
IOFileFilter dirFilter = FileFilterUtils.notFileFilter(FileFilterUtils.nameFileFilter("bad"));
IOFileFilter fileFilter = FileFilterUtils.suffixFileFilter(".xml");
FileFinder finder = new FileFinder(dirFilter, fileFilter, -1);
List files = finder.find(new File("."));
{code}
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (IO-172) Support directory scanning
based on Ant-like include/exclude patterns
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601190#action_12601190 ]
niallp edited comment on IO-172 at 5/30/08 9:25 AM:
-------------------------------------------------------------
> how would one search for files that match "*/.xml" but that don't match "bad/**"?
Currently, the way would be to create a DirectoryWalker implementation:
{code:java}
public class FileFinder extends DirectoryWalker {
public FileFinder(IOFileFilter dirFilter, IOFileFilter fileFilter, int depthLimit) {
super(dirFilter, fileFilter, depthLimit);
}
/** find files. */
public List find(File startDirectory) throws IOException {
List results = new ArrayList();
walk(startDirectory, results);
return results;
}
/** Handles a directory end by adding the File to the result set. */
protected void handleDirectoryEnd(File directory, int depth, Collection results) {
results.add(directory);
}
/** Handles a file by adding the File to the result set. */
protected void handleFile(File file, int depth, Collection results) {
results.add(file);
}
}
{code}
Then you use the file filter implementations to achieve what you want:
{code:java}
IOFileFilter dirFilter = FileFilterUtils.notFileFilter(FileFilterUtils.nameFileFilter("bad"));
IOFileFilter fileFilter = FileFilterUtils.suffixFileFilter(".xml");
FileFinder finder = new FileFinder(dirFilter, fileFilter, -1);
List files = finder.find(new File("."));
{code}
was (Author: niallp):
> how would one search for files that match "*/.xml" but that don't match "bad/**"?
Currently, the way would be to create a DirectoryWalker implementation:
{code:java}
public class FileFinder extends DirectoryWalker {
public FileFinder(IOFileFilter dirFilter, IOFileFilter fileFilter, int depthLimit) {
super(dirFilter, fileFilter, depthLimit);
}
public List find(File startDirectory) {
List results = new ArrayList();
try {
walk(startDirectory, results);
} catch(IOException ex) {
Assert.fail(ex.toString());
}
return results;
}
/** Handles a directory end by adding the File to the result set. */
protected void handleDirectoryEnd(File directory, int depth, Collection results) {
results.add(directory);
}
/** Handles a file by adding the File to the result set. */
protected void handleFile(File file, int depth, Collection results) {
results.add(file);
}
}
{code}
Then you use the file filter implementations to achieve what you want:
{code:java}
IOFileFilter dirFilter = FileFilterUtils.notFileFilter(FileFilterUtils.nameFileFilter("bad"));
IOFileFilter fileFilter = FileFilterUtils.suffixFileFilter(".xml");
FileFinder finder = new FileFinder(dirFilter, fileFilter, -1);
List files = finder.find(new File("."));
{code}
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (IO-172) Support directory scanning
based on Ant-like include/exclude patterns
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601190#action_12601190 ]
niallp edited comment on IO-172 at 5/30/08 9:23 AM:
-------------------------------------------------------------
> how would one search for files that match "*/.xml" but that don't match "bad/**"?
Currently, the way would be to create a DirectoryWalker implementation:
{code:java}
public class FileFinder extends DirectoryWalker {
public FileFinder(IOFileFilter dirFilter, IOFileFilter fileFilter, int depthLimit) {
super(dirFilter, fileFilter, depthLimit);
}
public List find(File startDirectory) {
List results = new ArrayList();
try {
walk(startDirectory, results);
} catch(IOException ex) {
Assert.fail(ex.toString());
}
return results;
}
/** Handles a directory end by adding the File to the result set. */
protected void handleDirectoryEnd(File directory, int depth, Collection results) {
results.add(directory);
}
/** Handles a file by adding the File to the result set. */
protected void handleFile(File file, int depth, Collection results) {
results.add(file);
}
}
{code}
Then you use the file filter implementations to achieve what you want:
{code:java}
IOFileFilter dirFilter = FileFilterUtils.notFileFilter(FileFilterUtils.nameFileFilter("bad"));
IOFileFilter fileFilter = FileFilterUtils.suffixFileFilter(".xml");
FileFinder finder = new FileFinder(dirFilter, fileFilter, -1);
List files = finder.find(new File("."));
{code}
was (Author: niallp):
> how would one search for files that match "*/.xml" but that don't match "bad/**"?
Currently, the way would be to create a DirectoryWalker implementation:
{code:java}
public class FileFinder extends DirectoryWalker {
public FileFinder(IOFileFilter dirFilter, IOFileFilter fileFilter, int depthLimit) {
super(dirFilter, fileFilter, depthLimit);
}
protected List find(File startDirectory) {
List results = new ArrayList();
try {
walk(startDirectory, results);
} catch(IOException ex) {
Assert.fail(ex.toString());
}
return results;
}
/** Handles a directory end by adding the File to the result set. */
protected void handleDirectoryEnd(File directory, int depth, Collection results) {
results.add(directory);
}
/** Handles a file by adding the File to the result set. */
protected void handleFile(File file, int depth, Collection results) {
results.add(file);
}
}
{code}
Then you use the file filter implementations to achieve what you want:
{code:java}
IOFileFilter dirFilter = FileFilterUtils.notFileFilter(FileFilterUtils.nameFileFilter("bad"));
IOFileFilter fileFilter = FileFilterUtils.suffixFileFilter(".xml");
FileFinder finder = new FileFinder(dirFilter, fileFilter, -1);
List files = finder.find(new File("."));
{code}
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IO-172) Support directory scanning based on
Ant-like include/exclude patterns
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated IO-172:
-------------------------------
Fix Version/s: 2.x
Sorry for the delay in reposning Matt,. I'm against just dumping an impementation from elsewhere that duplicates much of the code thats already in IO. But if someone wants to come up with one that re-uses existing IO code such as directory walker and the file filter implementations the I'm OK with that.
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
> Fix For: 2.x
>
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (IO-172) Support directory scanning
based on Ant-like include/exclude patterns
Posted by "James Ring (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IO-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861492#action_12861492 ]
James Ring edited comment on IO-172 at 4/27/10 2:51 PM:
--------------------------------------------------------
This is just like http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Predicate.html and http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Predicates.html, except it's ugly and my hands hurt just looking at the example code above.
Nicer would be something like:
import static org.apache.commons.io.filefilter.IOFileFilters.*;
scanDirectory(new File("."), and(suffix(".xml"), not(name("bad"))));
was (Author: sjr):
This is just like http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Predicate.html and http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Predicates.html, except it's ugly and my hands hurt just looking at the example code above.
Nicer would be something like:
import static org.apache.commons.io.filefilter.IOFileFilters.*;
scanDirectory(and(suffix(".xml"), not(name("bad"))));
> Support directory scanning based on Ant-like include/exclude patterns
> ---------------------------------------------------------------------
>
> Key: IO-172
> URL: https://issues.apache.org/jira/browse/IO-172
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 1.4
> Reporter: Benjamin Bentmann
> Fix For: 2.x
>
>
> While IO offers a rich set of {{IOFileFilters}} for finding files in directories, I feel it's missing a concept similar to Ant's file sets. For example, how would one search for files that match "**/*.xml" but that don't match "bad/**"? The sketched example would require to exclude the directory "bad" but only if it is the first component of the path, something like "foo/bad/bar.xml" still needs to be included.
> Given the increased flexibility of [Ant-like patterns|http://ant.apache.org/manual/dirtasks.html#patterns], it would be cool to have something similar to Ant's [{{DirectoryScanner}}|http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?view=markup] available in Commons IO.
> Personally, I wouldn't need a full copy of the mentioned class, I believe some method like
> {code:java}
> Collection<String> scanDirectory(File dir, Collection<String> includes, Collection<String> excludes)
> {code}
> in {{FileUtils}} would just suffice. Some default excludes like SCM metadata files could be provided as a public static final and unmodifiable string collection. The return value should include path names relative to the base directory instead of absolute paths (it's easy for the caller to resolve the files against the base directory but it's error-prone to relativize absolute paths).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.